Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BurstCost aren't handling multi-consumers correctly #272

Closed
franz1981 opened this issue Nov 16, 2019 · 1 comment
Closed

BurstCost aren't handling multi-consumers correctly #272

franz1981 opened this issue Nov 16, 2019 · 1 comment
Labels
bug

Comments

@franz1981
Copy link
Collaborator

MpqBurstCost and QueueBurstCost aren't handling correctly multi-consumer scenario: see netty/netty#9078 (comment) for further explanations.
@nitsanw
Copy link
Contributor

nitsanw commented Nov 18, 2019

To capture the TL;DR from that thread, the benchmark assumes last message processed is sufficient for declaring the batch processed, but in an MC scenario this may not be true.

@nitsanw nitsanw added the bug label Nov 19, 2019
nitsanw added a commit that referenced this issue Nov 25, 2019
@nitsanw
Merge pull request #273 from franz1981/mc_burst_bench
9c354ce 
Fixes #272 BurstCost aren't handling multi-consumers correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nitsanw @franz1981