Merge upstream #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Handle SCALE_NONE mode when optimized for previews (previews are often smaller than the project size) * Fixing 2 memory leaks (thanks PeterM)
…sed by libopenshot, such as scaling mode for preview vs final render, or hardware decode, etc...
New Settings Class to be used for changing realtime settings used by libopenshot
* tests/CMakeFiles: Use FFMpeg like src/ * Use system jsoncpp in tests, too The tests/ build needs to use the same jsoncpp as the src/ build, or tests in Clip_Tests.cpp can fail. * Don't show FFMpeg version messages in tests/ Displaying the version-number messages twice seems like overkill
* Update readme to use markdown and update copyright to 2018 Add md extension to render in Github Wrap commercial details with horizontal rules Updating correct file and deleting duplicate * Update dates to 2019
* Integration of libresvg SVG library (optional during build) * Major refactor of max_width and max_height for preview optimization * Fixed many bugs related to preview resizing, with regards to cached frames * Updating gitlab CI to find RESVGDIR correctly for windows, and adding svgz support * Updating cmake findresvg module to search for windows locations first, to prevent an issue on our windows builders and updating some CMake output. * Removing folder path from resvg header, since it could be installed in different named folders. This is an attempt to fix Windows include issues. * Making call to AV_FREE_FRAME conditional for non windows systems (because it crashes on Windows for seemingly no reason). Needs more investigation.
* Search for libresvg.so in RESVGDIR also This means that RESVGDIR can be pointed to the `target/release` dir where resvg was built, and both `libresvg.so` and `include/resvg.h` will be found. * ReSVG: Fix up discovery module `find_package_handle_standard_args` is supposed to set the `_FOUND` variable automatically (as the comment right above it says), as well as handling things like REQUIRED, QUIETLY, etc. It should always be run at the end of a module, for this reason. This change removes the conditionals around the call, lets it handle what it's meant to handle, and defines a custom failure message for discovery that replaces the one in `src/CMakeList.txt`. In addition, the `REQRUIRED` is removed from `tests/CMakeLists.txt`, since it's _supposed_ to mark the module as required (which ReSVG is not), and was only working due to the aforementioned improper conditional wrapping of the module's cleanup. * FindRESVG.cmake does not set RESVG_DEFINITIONS Remove the comment that claims it does.
* First implementation of CRF (Constant Rate Factor) * Include AV1 in the codecs that can use crf * First version that uses SetOption to set crf quality * Clarify comments * Delete setting the bitrate for crf in SetVideoOption because it is not needed, it is set later with SetOptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.