Skip to content

Commit

Permalink
View: Fix calling virtual function from the destructor (#282)
Browse files Browse the repository at this point in the history
XXXViewはコンストラクタ内で仮想関数save_session()を呼び出していますが
仮想関数はコントラクタ内で派生クラスの関数として呼び出しできないため
cppcheckに警告されます。そのためスコープ解決演算子を使ってクラスを
明示します。

cppcheckのレポート
```
src/article/articleview.h:46:14: warning: Virtual function 'save_session' is called from destructor '~ArticleViewMain()' at line 78. Dynamic binding is not used. [virtualCallInConstructor]
        void save_session() override;
             ^
src/article/articleview.cpp:78:5: note: Calling save_session
    save_session();
    ^
src/article/articleview.h:46:14: note: save_session is a virtual function
        void save_session() override;
             ^
src/board/boardview.h:21:14: warning: Virtual function 'save_session' is called from destructor '~BoardView()' at line 54. Dynamic binding is not used. [virtualCallInConstructor]
        void save_session() override;
             ^
src/board/boardview.cpp:54:36: note: Calling save_session
    if( ! SESSION::is_quitting() ) save_session();
                                   ^
src/board/boardview.h:21:14: note: save_session is a virtual function
        void save_session() override;
             ^
```
  • Loading branch information
ma8ma committed May 16, 2020
1 parent 678376e commit 73c3336
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/article/articleview.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ ArticleViewMain::~ArticleViewMain()
std::cout << "ArticleViewMain::~ArticleViewMain : " << get_url() << " url_article = " << url_article() << std::endl;
#endif

save_session();
ArticleViewMain::save_session();

// 閉じたタブ履歴更新
HISTORY::append_history( URL_HISTCLOSEVIEW,
Expand Down
2 changes: 1 addition & 1 deletion src/board/boardview.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ BoardView::~BoardView()
DBTREE::board_name( get_url() ), TYPE_BOARD );


if( ! SESSION::is_quitting() ) save_session();
if( ! SESSION::is_quitting() ) BoardView::save_session();
}


Expand Down

0 comments on commit 73c3336

Please sign in to comment.