Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinkFilterDiag: Rename member function to avoid conflict with parent member #1263

Conversation

ma8ma
Copy link
Collaborator

@ma8ma ma8ma commented Sep 30, 2023

親クラスのメンバー関数と名前が重複しているとcppcheckに指摘されたため子クラスのメンバー関数の名前を変更します。

cppcheck 2.12.1のレポート

src/linkfilterpref.h:29:23: warning: The class 'LinkFilterDiag' defines member function with name 'get_url' also defined in its parent class 'PrefDiag'. [duplInheritedMember]
        Glib::ustring get_url() const { return m_entry_url.get_text(); }
                      ^
src/skeleton/prefdiag.h:32:28: note: Parent function 'PrefDiag::get_url'
        const std::string& get_url() const { return m_url; }
                           ^
src/linkfilterpref.h:29:23: note: Derived function 'LinkFilterDiag::get_url'
        Glib::ustring get_url() const { return m_entry_url.get_text(); }
                      ^

…member

親クラスのメンバー関数と名前が重複しているとcppcheckに指摘されたため
子クラスのメンバー関数の名前を変更します。

cppcheck 2.12.1のレポート
```
src/linkfilterpref.h:29:23: warning: The class 'LinkFilterDiag' defines member function with name 'get_url' also defined in its parent class 'PrefDiag'. [duplInheritedMember]
        Glib::ustring get_url() const { return m_entry_url.get_text(); }
                      ^
src/skeleton/prefdiag.h:32:28: note: Parent function 'PrefDiag::get_url'
        const std::string& get_url() const { return m_url; }
                           ^
src/linkfilterpref.h:29:23: note: Derived function 'LinkFilterDiag::get_url'
        Glib::ustring get_url() const { return m_entry_url.get_text(); }
                      ^
```
@ma8ma ma8ma added the refactoring コードの整理 (バグ修正でも機能変更でもない) label Sep 30, 2023
@ma8ma ma8ma merged commit cb13c3d into master Sep 30, 2023
20 checks passed
@ma8ma ma8ma deleted the linkfilterdiag-rename-member-function-to-avoid-conflict-with-parent-member branch September 30, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring コードの整理 (バグ修正でも機能変更でもない)
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant