Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compiler warnings for -Wimplicit-int-conversion part1 #1378

Merged
merged 1 commit into from Apr 6, 2024
Merged

Fix compiler warnings for -Wimplicit-int-conversion part1 #1378

merged 1 commit into from Apr 6, 2024

Commits on Apr 6, 2024

  1. Fix compiler warnings for -Wimplicit-int-conversion part1 

    整数型の変数をサイズが小さい整数型へ暗黙的に変換している箇所は
精度が失う可能性があるとclangに指摘されたため明示的にキャスト
`static_cast<...>()`を使ったり、整数型を変更してコンパイラに
意図した変更であると伝えます。

clang 17のレポート (file pathを一部省略)
```
src/article/drawareabase.cpp:2444:33: warning: implicit conversion loses integer precision: 'const int' to 'char' [-Wimplicit-int-conversion]
src/article/drawareabase.cpp:2451:20: warning: implicit conversion loses integer precision: 'const int' to 'char' [-Wimplicit-int-conversion]
src/article/drawareabase.cpp:2460:20: warning: implicit conversion loses integer precision: 'const int' to 'char' [-Wimplicit-int-conversion]
src/article/drawareabase.cpp:2467:16: warning: implicit conversion loses integer precision: 'const int' to 'char' [-Wimplicit-int-conversion]
src/article/drawareabase.cpp:2471:12: warning: implicit conversion loses integer precision: 'const int' to 'char' [-Wimplicit-int-conversion]
src/article/layouttree.cpp:122:23: warning: implicit conversion loses integer precision: 'const int' to 'unsigned char' [-Wimplicit-int-conversion]
src/control/controlutil.cpp:291:18: warning: implicit conversion loses integer precision: 'const guint' (aka 'const unsigned int') to 'char' [-Wimplicit-int-conversion]
src/dbtree/nodetreebase.cpp:864:25: warning: implicit conversion loses integer precision: 'const int' to 'unsigned char' [-Wimplicit-int-conversion]
src/dbtree/nodetreebase.cpp:866:31: warning: implicit conversion loses integer precision: 'const int' to 'unsigned char' [-Wimplicit-int-conversion]
src/jdlib/misccharcode.cpp:493:22: warning: implicit conversion loses integer precision: 'const char32_t' to 'char' [-Wimplicit-int-conversion]
src/jdlib/misccharcode.cpp:497:31: warning: implicit conversion loses integer precision: 'unsigned int' to 'char' [-Wimplicit-int-conversion]
src/jdlib/misccharcode.cpp:498:31: warning: implicit conversion changes signedness: 'unsigned int' to 'char' [-Wsign-conversion]
src/jdlib/misccharcode.cpp:502:31: warning: implicit conversion loses integer precision: 'unsigned int' to 'char' [-Wimplicit-int-conversion]
src/jdlib/misccharcode.cpp:503:31: warning: implicit conversion changes signedness: 'unsigned int' to 'char' [-Wsign-conversion]
src/jdlib/misccharcode.cpp:504:31: warning: implicit conversion changes signedness: 'unsigned int' to 'char' [-Wsign-conversion]
src/jdlib/misccharcode.cpp:508:31: warning: implicit conversion loses integer precision: 'unsigned int' to 'char' [-Wimplicit-int-conversion]
src/jdlib/miscutil.cpp:1476:39: warning: implicit conversion loses integer precision: 'int' to 'unsigned char' [-Wimplicit-int-conversion]
src/jdlib/miscutil.cpp:1477:43: warning: implicit conversion loses integer precision: 'int' to 'unsigned char' [-Wimplicit-int-conversion]
```
    @ma8ma
    ma8ma committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    4131283 View commit details
    Browse the repository at this point in the history