Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace char buffer with std::string for MISC::Iconv() #166

Merged
merged 1 commit into from Jan 5, 2020
Merged

Replace char buffer with std::string for MISC::Iconv() #166

merged 1 commit into from Jan 5, 2020

Conversation

ma8ma
Copy link
Collaborator

@ma8ma ma8ma commented Jan 4, 2020 •
edited

malloc/freeで確保しているバッファをstd::stringで置き換えます。
引数の文字列は渡す先がchar*を要求しているためバッファのコピーが必要です。

関連のpull request: #159

@ma8ma
Replace char buffer with std::string for MISC::Iconv()
22dc9c1 
malloc/freeで確保しているバッファをstd::stringで置き換える。
引数の文字列は渡す先がchar*を要求しているためバッファのコピーが必要。
@ma8ma ma8ma added the refactoring コードの整理 (バグ修正でも機能変更でもない) label Jan 4, 2020
@ma8ma ma8ma added this to In progress in State of JDim-v0.2.0+ via automation Jan 4, 2020
@ma8ma ma8ma marked this pull request as ready for review January 5, 2020 05:56
@ma8ma ma8ma merged commit 47752c6 into JDimproved:master Jan 5, 2020
State of JDim-v0.2.0+ automation moved this from In progress to Done Jan 5, 2020
@ma8ma ma8ma deleted the replace-char-buffer-part3 branch January 5, 2020 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactoring コードの整理 (バグ修正でも機能変更でもない)
Projects
No open projects
State of JDim-v0.2.0+
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ma8ma