Commits on May 16, 2020

1. View: Fix calling virtual function from the destructor …

   XXXViewはコンストラクタ内で仮想関数save_session()を呼び出していますが
   仮想関数はコントラクタ内で派生クラスの関数として呼び出しできないため
   cppcheckに警告されます。そのためスコープ解決演算子を使ってクラスを
   明示します。
   
   cppcheckのレポート
   ```
   src/article/articleview.h:46:14: warning: Virtual function 'save_session' is called from destructor '~ArticleViewMain()' at line 78. Dynamic binding is not used. [virtualCallInConstructor]
           void save_session() override;
                ^
   src/article/articleview.cpp:78:5: note: Calling save_session
       save_session();
       ^
   src/article/articleview.h:46:14: note: save_session is a virtual function
           void save_session() override;
                ^
   src/board/boardview.h:21:14: warning: Virtual function 'save_session' is called from destructor '~BoardView()' at line 54. Dynamic binding is not used. [virtualCallInConstructor]
           void save_session() override;
                ^
   src/board/boardview.cpp:54:36: note: Calling save_session
       if( ! SESSION::is_quitting() ) save_session();
                                      ^
   src/board/boardview.h:21:14: note: save_session is a virtual function
           void save_session() override;
                ^
   ```

   

   ma8ma committed May 16, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for f831112
   • Browse repository at this point

   Copy the full SHA

   f831112 View commit details

   Browse the repository at this point in the history