ArticleBase: Fix calling virtual function from the destructor #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArticleBaseはデストラクタ内で仮想関数unlock_impl()を呼び出していますが
仮想関数はデストラクタ内で派生クラスの関数として呼び出しできないため
cppcheckに警告されます。そのためスコープ解決演算子を使ってクラスを
明示します。
cppehckのレポート
```
src/dbtree/articlebase.h:420:14: warning: Virtual function 'unlock_impl' is called from destructor '~ArticleBase()' at line 120. Dynamic binding is not used. [virtualCallInConstructor]
void unlock_impl() override;
^
src/dbtree/articlebase.cpp:120:5: note: Calling unlock_impl
unlock_impl();
^
src/dbtree/articlebase.h:420:14: note: unlock_impl is a virtual function
void unlock_impl() override;
^
```
ma8ma
commented
May 16, 2020
| @@ -117,7 +117,7 @@ ArticleBase::~ArticleBase() | |||
| assert( get_lock() == 0 ); | |||
|
|
|||
| // nodetreeのクリアと情報保存 | |||
| unlock_impl(); | |||
| ArticleBase::unlock_impl(); | |||
There was a problem hiding this comment.
RefPtr_lock、Lockableと合わせて参照カウント方式のスマートポインターを実装しています。
標準ライブラリに置き換えられないかそのうち検証したいと思います。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ArticleBaseはデストラクタ内で仮想関数unlock_impl()を呼び出していますが、仮想関数はデストラクタ内で派生クラスの関数として呼び出しできないためcppcheckに警告されます。
そのためスコープ解決演算子を使ってクラスを明示します。
cppehckのレポート