std:stringアクセスのチェックの修正 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
http://mao.5ch.net/test/read.cgi/linux/1516535816/69 の 「ダブルクォート」と「スペースで改行」と「左のタブが閉じる」件の修正
ooinu
pushed a commit
to ooinu/JDim
that referenced
this pull request
Dec 22, 2018
GTK3サポートを追加する(開発版) jd-2.90.0-alpha20180918 からの変更点 * コーディングスタイルを変更し1行の最大文字数は設定しなくなった コードは読みやすい位置で改行する * README.mdやINSTALLに情報を追加しC++11の機能を使うことを明確にした * 新たに見つけた不具合を修正した * 複雑だったコードを書き直した 詳細はPull Requestを参照してください ma8ma#2 Closes JDimproved#2, closes JDimproved#3, and closes JDimproved#5
ma8ma
added a commit
that referenced
this pull request
May 16, 2020
タイマーを使うコードで寿命管理が徹底されていなかったためメモリリークが
発生していた。スマートポインターを返すように変更してリークを修正する。
gcc-9のログ
```
Direct leak of 24 byte(s) in 1 object(s) allocated from:
#0 0x7f18a17e03d1 in operator new(unsigned long) (/lib/x86_64-linux-gnu/liblsan.so.0+0x103d1)
#1 0x55ff4e8a91f5 in JDLIB::Timeout::connect(sigc::slot<bool, sigc::nil, sigc::nil, sigc::nil, sigc::nil, sigc::nil, sigc::nil, sigc::nil>, unsigned int) src/jdlib/timeout.cpp:54
#2 0x55ff4df0f034 in ARTICLE::ArticleViewMain::show_instruct_diag() src/article/articleview.cpp:654
#3 0x55ff4df15888 in ARTICLE::ArticleViewMain::update_finish() src/article/articleview.cpp:593
#4 0x55ff4e3ed537 in SKELETON::Admin::update_finish(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) src/skeleton/admin.cpp:1645
```
ma8ma
added a commit
that referenced
this pull request
Jun 10, 2023
AddressSanitizerを有効にしてスレビューを表示したときに
`Pango::FontMetrics`のオブジェクトが開放されず
メモリリークが発生したためC APIに書き直して修正します。
AddressSanitizerのレポート
```
Direct leak of 40 byte(s) in 1 object(s) allocated from:
#0 0x7fd2d34decaf in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:69
#1 0x7fd2d1fa1948 in g_malloc (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x5f948) (BuildId: 88d7a1c8d79fc1becb2737be566dd98523394d55)
#2 0x55c83a6e64a6 in ARTICLE::DrawAreaBase::init_font() ../src/article/drawareabase.cpp:357
#3 0x55c83a6f14b7 in ARTICLE::DrawAreaBase::clear_screen() ../src/article/drawareabase.cpp:742
(snip)
Direct leak of 40 byte(s) in 1 object(s) allocated from:
#0 0x7fd2d34decaf in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:69
#1 0x7fd2d1fa1948 in g_malloc (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x5f948) (BuildId: 88d7a1c8d79fc1becb2737be566dd98523394d55)
#2 0x55c83a6e64a6 in ARTICLE::DrawAreaBase::init_font() ../src/article/drawareabase.cpp:357
#3 0x55c83a6df61b in ARTICLE::DrawAreaBase::setup(bool, bool, bool) ../src/article/drawareabase.cpp:211
(snip)
```
ma8ma
added a commit
that referenced
this pull request
Jun 10, 2023
AddressSanitizerを有効にしてスレビューを表示したときに
`Pango::FontMetrics`のオブジェクトが開放されず
メモリリークが発生したためC APIに書き直して修正します。
AddressSanitizerのレポート
```
Direct leak of 40 byte(s) in 1 object(s) allocated from:
#0 0x7fd2d34decaf in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:69
#1 0x7fd2d1fa1948 in g_malloc (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x5f948) (BuildId: 88d7a1c8d79fc1becb2737be566dd98523394d55)
#2 0x55c83a6e64a6 in ARTICLE::DrawAreaBase::init_font() ../src/article/drawareabase.cpp:357
#3 0x55c83a6f14b7 in ARTICLE::DrawAreaBase::clear_screen() ../src/article/drawareabase.cpp:742
(snip)
Direct leak of 40 byte(s) in 1 object(s) allocated from:
#0 0x7fd2d34decaf in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:69
#1 0x7fd2d1fa1948 in g_malloc (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x5f948) (BuildId: 88d7a1c8d79fc1becb2737be566dd98523394d55)
#2 0x55c83a6e64a6 in ARTICLE::DrawAreaBase::init_font() ../src/article/drawareabase.cpp:357
#3 0x55c83a6df61b in ARTICLE::DrawAreaBase::setup(bool, bool, bool) ../src/article/drawareabase.cpp:211
(snip)
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
すみません...これで直ると思います。
http://mao.5ch.net/test/read.cgi/linux/1516535816/69 の
「ダブルクォート」と「スペースで改行」と「左のタブが閉じる」件の修正