Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused local variables #339

Merged
merged 1 commit into from Jun 13, 2020

Conversation

ma8ma
Copy link
Collaborator

@ma8ma ma8ma commented Jun 13, 2020

未使用の変数が存在するとcppcheckに指摘されたため削除します。

cppcheckのレポート

src/article/embeddedimage.cpp:135:17: style: Unused variable: errmsg [unusedVariable]
    std::string errmsg;
                ^
src/config/configitems.cpp:485:30: style: Unused variable: list_tmp [unusedVariable]
    std::list< std::string > list_tmp;
                             ^
src/config/configitems.cpp:486:40: style: Unused variable: it_tmp [unusedVariable]
    std::list< std::string >::iterator it_tmp;
                                       ^
src/bbslist/bbslistviewbase.cpp:3004:32: style: Unused variable: list_path [unusedVariable]
    std::list< Gtk::TreePath > list_path;
                               ^
src/dbimg/img.cpp:780:34: style: Unused variable: list_tmp [unusedVariable]
        std::list< std::string > list_tmp;
                                 ^
src/dbimg/img.cpp:781:44: style: Unused variable: it_tmp [unusedVariable]
        std::list< std::string >::iterator it_tmp;
                                           ^
src/globalabonethreadpref.h:65:25: style: Unused variable: str_name [unusedVariable]
            std::string str_name, str_word, str_regex;
                        ^

未使用の変数が存在するとcppcheckに指摘されたため削除します。

cppcheckのレポート
```
src/article/embeddedimage.cpp:135:17: style: Unused variable: errmsg [unusedVariable]
    std::string errmsg;
                ^
src/config/configitems.cpp:485:30: style: Unused variable: list_tmp [unusedVariable]
    std::list< std::string > list_tmp;
                             ^
src/config/configitems.cpp:486:40: style: Unused variable: it_tmp [unusedVariable]
    std::list< std::string >::iterator it_tmp;
                                       ^
src/bbslist/bbslistviewbase.cpp:3004:32: style: Unused variable: list_path [unusedVariable]
    std::list< Gtk::TreePath > list_path;
                               ^
src/dbimg/img.cpp:780:34: style: Unused variable: list_tmp [unusedVariable]
        std::list< std::string > list_tmp;
                                 ^
src/dbimg/img.cpp:781:44: style: Unused variable: it_tmp [unusedVariable]
        std::list< std::string >::iterator it_tmp;
                                           ^
src/globalabonethreadpref.h:65:25: style: Unused variable: str_name [unusedVariable]
            std::string str_name, str_word, str_regex;
                        ^
```
@ma8ma ma8ma added the refactoring コードの整理 (バグ修正でも機能変更でもない) label Jun 13, 2020
@ma8ma ma8ma merged commit 552cf7f into JDimproved:master Jun 13, 2020
@ma8ma ma8ma added this to Done in State of JDim-v0.3.0+ via automation Jun 13, 2020
@ma8ma ma8ma deleted the remove-unused-local-variables branch June 13, 2020 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring コードの整理 (バグ修正でも機能変更でもない)
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant