Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImageViewBase: Move local variables to inner scope to avoid shadowing #351

Merged
merged 1 commit into from
Jun 21, 2020
Merged

ImageViewBase: Move local variables to inner scope to avoid shadowing #351

merged 1 commit into from
Jun 21, 2020

Commits on Jun 21, 2020

  1. ImageViewBase: Move local variables to inner scope to avoid shadowing 

    ローカル変数の名前がシャドウイングされているとcppcheckに指摘されたため
内側のスコープへ変数宣言を移動します。

cppcheckのレポート
```
src/image/imageviewbase.cpp:1200:43: style: Local variable 'tact' shadows outer variable [shadowVariable]
        Glib::RefPtr< Gtk::ToggleAction > tact = Glib::RefPtr< Gtk::ToggleAction >::cast_dynamic( act );
                                          ^
src/image/imageviewbase.cpp:1192:39: note: Shadowed declaration
    Glib::RefPtr< Gtk::ToggleAction > tact;
                                      ^
src/image/imageviewbase.cpp:1200:43: note: Shadow variable
        Glib::RefPtr< Gtk::ToggleAction > tact = Glib::RefPtr< Gtk::ToggleAction >::cast_dynamic( act );
                                          ^
```
    @ma8ma
    ma8ma committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    c9008e3 View commit details
    Browse the repository at this point in the history