Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDWinMain: Unite if-statement blocks for same condition #382

Merged

Commits on Jul 4, 2020

  1. JDWinMain: Unite if-statement blocks for same condition

    隣り合うif文が同じ条件であるとcppcheckに指摘されたためブロックを
    まとめます。
    
    cppcheckのレポート
    ```
    src/winmain.cpp:281:9: style: The if condition is the same as the previous if condition [duplicateCondition]
        if( m_cancel_state_event ) return Gtk::Window::on_window_state_event( event );
            ^
    src/winmain.cpp:277:9: note: First condition
        if( m_cancel_state_event ) std::cout << "cancel\n";
            ^
    src/winmain.cpp:281:9: note: Second condition
        if( m_cancel_state_event ) return Gtk::Window::on_window_state_event( event );
            ^
    src/winmain.cpp:295:9: style: The if condition is the same as the previous if condition [duplicateCondition]
        if( m_cancel_state_event ) return Gtk::Window::on_configure_event( event );
            ^
    src/winmain.cpp:291:9: note: First condition
        if( m_cancel_state_event ) std::cout << "cancel\n";
            ^
    src/winmain.cpp:295:9: note: Second condition
        if( m_cancel_state_event ) return Gtk::Window::on_configure_event( event );
            ^
    ```
    ma8ma committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    1b6e56c View commit details
    Browse the repository at this point in the history