Replace JDLIB::hash_set_thread with std::unordered_set #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
従来のstd::vectorとstd::setを使うhash_set_threadの替わりに std::unordered_setを使う。 前提条件 hash_set_threadはURL文字列を格納し検索に使われる 扱うURLは100件を超えることがある 比較 従来の方法よりstd::unordered_setを使うほうが挿入時の計算が簡明になり 検索速度も速い。 従来: hash -> modulo -> indexing(std::vector) -> insert(std::set) 新しい: hash -> insert(std::unordered_set) 事前に要素数が分かる箇所ではstd::unordered_set::reserve()で 要素数を設定すれば挿入中のメモリ再配置を回避できる。
|
おーいいですね |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
従来の
std::vectorとstd::setを使うJDLIB::hash_set_threadの替わりにstd::unordered_setを使います。また、使われなくなったhash_set_threadのヘッダーと実装ファイルを削除します。前提条件
hash_set_threadはURL文字列を格納し検索に使われる比較
従来の方法より
std::unordered_setを使うほうが挿入時の計算が簡明になり検索速度も速いです。事前に要素数が分かる箇所では
std::unordered_set::reserve()で要素数を設定して挿入中のメモリ再配置を回避するようにします。