Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Gdk::RGBA instead of Gdk::Color #448

Merged
merged 1 commit into from Aug 23, 2020

Conversation

ma8ma
Copy link
Collaborator

@ma8ma ma8ma commented Aug 23, 2020

GTK4で削除されるGtk::ColorのかわりにGtk::RGBAを使います。

非推奨のシンボルを無効化するマクロ

GDK_DISABLE_DEPRECATED
GTK_DISABLE_DEPRECATED
GDKMM_DISABLE_DEPRECATED
GTKMM_DISABLE_DEPRECATED
GIOMM_DISABLE_DEPRECATED
GLIBMM_DISABLE_DEPRECATED
コンパイラのレポート
../src/bbslist/columns.cpp:26:107: error: invalid use of incomplete type 'class Gdk::Color'
   26 |     if( type == TYPE_COMMENT ) row[ m_fgcolor ] = Gdk::Color( CONFIG::get_color( COLOR_CHAR_BBS_COMMENT ) );
      |                                                                                                           ^
../src/bbslist/bbslistviewbase.cpp:617:121: error: invalid use of incomplete type 'class Gdk::Color'
  617 |         if( type == TYPE_COMMENT ) row[ m_columns.m_fgcolor ] = Gdk::Color( CONFIG::get_color( COLOR_CHAR_BBS_COMMENT ) );
      |                                                                                                                         ^
../src/image/imageareaicon.cpp:170:104: error: invalid use of incomplete type 'class Gdk::Color'
  170 |         m_pixbuf_loading->fill( MISC::color_to_int( Gdk::Color( CONFIG::get_color( COLOR_IMG_LOADING ) ) ) );
      |                                                                                                        ^
../src/image/imageareaicon.cpp:171:96: error: invalid use of incomplete type 'class Gdk::Color'
  171 |         m_pixbuf_err->fill( MISC::color_to_int( Gdk::Color( CONFIG::get_color( COLOR_IMG_ERR ) ) ) );
      |                                                                                                ^
../src/jdlib/miscgtk.cpp:21:16: error: invalid use of incomplete type 'const class Gdk::Color'
   21 |     l_rgb[0] = color.get_red();
      |                ^~~~~
../src/jdlib/miscgtk.cpp:22:16: error: invalid use of incomplete type 'const class Gdk::Color'
   22 |     l_rgb[1] = color.get_green();
      |                ^~~~~
../src/jdlib/miscgtk.cpp:23:16: error: invalid use of incomplete type 'const class Gdk::Color'
   23 |     l_rgb[2] = color.get_blue();
      |                ^~~~~
../src/jdlib/miscgtk.cpp:102:19: error: invalid use of incomplete type 'const class Gdk::Color'
  102 |     guint32 red = color.get_red() >> 8;
      |                   ^~~~~
../src/jdlib/miscgtk.cpp:103:21: error: invalid use of incomplete type 'const class Gdk::Color'
  103 |     guint32 green = color.get_green() >> 8;
      |                     ^~~~~
../src/jdlib/miscgtk.cpp:104:20: error: invalid use of incomplete type 'const class Gdk::Color'
  104 |     guint32 blue = color.get_blue() >> 8;
      |                    ^~~~~
../src/core.cpp:1679:31: error: variable 'Gdk::Color color' has initializer but incomplete type
 1679 |     Gdk::Color color( CONFIG::get_color( id ) );
      |                               ^~~~~~~~~
../src/fontcolorpref.cpp:457:74: error: invalid use of incomplete type 'class Gdk::Color'
  457 |         sel->set_current_color( Gdk::Color( CONFIG::get_color( colorid ) ) );
      |                                                                          ^
../src/fontcolorpref.cpp:457:74: error: invalid use of incomplete type 'class Gdk::Color'
  457 |         sel->set_current_color( Gdk::Color( CONFIG::get_color( colorid ) ) );
      |                                                                          ^
../src/core.cpp:1679:31: error: variable 'Gdk::Color color' has initializer but incomplete type
 1679 |     Gdk::Color color( CONFIG::get_color( id ) );
      |                               ^~~~~~~~~

関連のissue: #229

GTK4で削除される`Gtk::Color`のかわりに`Gtk::RGBA`を使います。

非推奨のシンボルを無効化するマクロ
```
GDK_DISABLE_DEPRECATED
GTK_DISABLE_DEPRECATED
GDKMM_DISABLE_DEPRECATED
GTKMM_DISABLE_DEPRECATED
GIOMM_DISABLE_DEPRECATED
GLIBMM_DISABLE_DEPRECATED
```

コンパイラのレポート
```
../src/bbslist/columns.cpp:26:107: error: invalid use of incomplete type 'class Gdk::Color'
   26 |     if( type == TYPE_COMMENT ) row[ m_fgcolor ] = Gdk::Color( CONFIG::get_color( COLOR_CHAR_BBS_COMMENT ) );
      |                                                                                                           ^
../src/bbslist/bbslistviewbase.cpp:617:121: error: invalid use of incomplete type 'class Gdk::Color'
  617 |         if( type == TYPE_COMMENT ) row[ m_columns.m_fgcolor ] = Gdk::Color( CONFIG::get_color( COLOR_CHAR_BBS_COMMENT ) );
      |                                                                                                                         ^
../src/image/imageareaicon.cpp:170:104: error: invalid use of incomplete type 'class Gdk::Color'
  170 |         m_pixbuf_loading->fill( MISC::color_to_int( Gdk::Color( CONFIG::get_color( COLOR_IMG_LOADING ) ) ) );
      |                                                                                                        ^
../src/image/imageareaicon.cpp:171:96: error: invalid use of incomplete type 'class Gdk::Color'
  171 |         m_pixbuf_err->fill( MISC::color_to_int( Gdk::Color( CONFIG::get_color( COLOR_IMG_ERR ) ) ) );
      |                                                                                                ^
../src/jdlib/miscgtk.cpp:21:16: error: invalid use of incomplete type 'const class Gdk::Color'
   21 |     l_rgb[0] = color.get_red();
      |                ^~~~~
../src/jdlib/miscgtk.cpp:22:16: error: invalid use of incomplete type 'const class Gdk::Color'
   22 |     l_rgb[1] = color.get_green();
      |                ^~~~~
../src/jdlib/miscgtk.cpp:23:16: error: invalid use of incomplete type 'const class Gdk::Color'
   23 |     l_rgb[2] = color.get_blue();
      |                ^~~~~
../src/jdlib/miscgtk.cpp:102:19: error: invalid use of incomplete type 'const class Gdk::Color'
  102 |     guint32 red = color.get_red() >> 8;
      |                   ^~~~~
../src/jdlib/miscgtk.cpp:103:21: error: invalid use of incomplete type 'const class Gdk::Color'
  103 |     guint32 green = color.get_green() >> 8;
      |                     ^~~~~
../src/jdlib/miscgtk.cpp:104:20: error: invalid use of incomplete type 'const class Gdk::Color'
  104 |     guint32 blue = color.get_blue() >> 8;
      |                    ^~~~~
../src/core.cpp:1679:31: error: variable 'Gdk::Color color' has initializer but incomplete type
 1679 |     Gdk::Color color( CONFIG::get_color( id ) );
      |                               ^~~~~~~~~
../src/fontcolorpref.cpp:457:74: error: invalid use of incomplete type 'class Gdk::Color'
  457 |         sel->set_current_color( Gdk::Color( CONFIG::get_color( colorid ) ) );
      |                                                                          ^
../src/fontcolorpref.cpp:457:74: error: invalid use of incomplete type 'class Gdk::Color'
  457 |         sel->set_current_color( Gdk::Color( CONFIG::get_color( colorid ) ) );
      |                                                                          ^
../src/core.cpp:1679:31: error: variable 'Gdk::Color color' has initializer but incomplete type
 1679 |     Gdk::Color color( CONFIG::get_color( id ) );
      |                               ^~~~~~~~~
```
@ma8ma ma8ma added gtk3 GTK3版に関するトピック refactoring コードの整理 (バグ修正でも機能変更でもない) labels Aug 23, 2020
@ma8ma ma8ma added this to In progress in State of JDim-v0.4.0+ via automation Aug 23, 2020
@ma8ma ma8ma merged commit aff5cba into JDimproved:master Aug 23, 2020
State of JDim-v0.4.0+ automation moved this from In progress to Done Aug 23, 2020
@ma8ma ma8ma deleted the use-gdk-rgba-instead-of-gdk-color branch August 23, 2020 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gtk3 GTK3版に関するトピック refactoring コードの整理 (バグ修正でも機能変更でもない)
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant