Use icon theme instead of Gtk::Arrow #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GTK4で廃止される`Gtk::Arrow`のかわりにアイコンテーマを使います。
GtkArrowのリファレンス[*]より
> GtkArrow has been deprecated; you can simply use a GtkImage with
> a suitable icon name, such as "pan-down-symbolic".
非推奨のシンボルを無効化するマクロ
```
GDK_DISABLE_DEPRECATED
GTK_DISABLE_DEPRECATED
GDKMM_DISABLE_DEPRECATED
GTKMM_DISABLE_DEPRECATED
GIOMM_DISABLE_DEPRECATED
GLIBMM_DISABLE_DEPRECATED
```
コンパイラのレポート
```
../src/skeleton/tabswitchbutton.h:20:14: error: 'Arrow' in namespace 'Gtk' does not name a type
20 | Gtk::Arrow m_arrow{ Gtk::ARROW_DOWN, Gtk::SHADOW_NONE };
| ^~~~~
../src/skeleton/menubutton.h:28:14: error: 'Arrow' in namespace 'Gtk' does not name a type
28 | Gtk::Arrow* m_arrow;
| ^~~~~
```
[*]: https://developer.gnome.org/gtk3/stable/GtkArrow.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GTK4で廃止される
Gtk::Arrowのかわりにアイコンテーマを使います。GtkArrowのリファレンスより
非推奨のシンボルを無効化するマクロ
コンパイラのレポート
関連のissue: #229