Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Gtk::Dialog::get_content_area() instead of get_vbox() part2 #466

Conversation

ma8ma
Copy link
Collaborator

@ma8ma ma8ma commented Sep 19, 2020

GTK4で廃止されるGtk::Dialog::get_vbox()のかわりにGtk::Dialog::get_content_area()を使います。

非推奨のシンボルを無効化するマクロ

GDK_DISABLE_DEPRECATED
GTK_DISABLE_DEPRECATED
GDKMM_DISABLE_DEPRECATED
GTKMM_DISABLE_DEPRECATED
GIOMM_DISABLE_DEPRECATED
GLIBMM_DISABLE_DEPRECATED

コンパイラのレポート

../src/control/mousekeypref.cpp:41:5: error: 'get_vbox' was not declared in this scope
   41 |     get_vbox()->pack_start( m_label );
      |     ^~~~~~~~
../src/control/mousekeypref.cpp:301:5: error: 'get_vbox' was not declared in this scope
  301 |     get_vbox()->set_spacing( 8 );
      |     ^~~~~~~~
../src/control/mousekeypref.cpp:532:5: error: 'get_vbox' was not declared in this scope
  532 |     get_vbox()->set_spacing( 8 );
      |     ^~~~~~~~
../src/dbimg/delimgcachediag.cpp:34:5: error: 'get_vbox' was not declared in this scope
   34 |     get_vbox()->set_spacing( mrg );
      |     ^~~~~~~~
../src/dbimg/delimgdiag.h:110:13: error: 'get_vbox' was not declared in this scope
  110 |             get_vbox()->set_spacing( 8 );
      |             ^~~~~~~~
../src/fontcolorpref.cpp:241:5: error: 'get_vbox' was not declared in this scope
  241 |     get_vbox()->pack_start( m_notebook );
      |     ^~~~~~~~
../src/globalabonepref.h:73:13: error: 'get_vbox' was not declared in this scope
   73 |             get_vbox()->pack_start( m_notebook );
      |             ^~~~~~~~
../src/globalabonethreadpref.h:116:13: error: 'get_vbox' was not declared in this scope
  116 |             get_vbox()->pack_start( m_notebook );
      |             ^~~~~~~~
../src/image/preference.cpp:76:5: error: 'get_vbox' was not declared in this scope
   76 |     get_vbox()->pack_start( m_vbox_info );
      |     ^~~~~~~~
../src/linkfilterpref.cpp:47:5: error: 'get_vbox' was not declared in this scope; did you mean 'm_vbox'?
   47 |     get_vbox()->set_spacing( 8 );
      |     ^~~~~~~~
      |     m_vbox
../src/linkfilterpref.cpp:113:5: error: 'get_vbox' was not declared in this scope
  113 |     get_vbox()->set_spacing( 8 );
      |     ^~~~~~~~
../src/livepref.cpp:66:5: error: 'get_vbox' was not declared in this scope; did you mean 'm_vbox'?
   66 |     get_vbox()->set_spacing( mrg );
      |     ^~~~~~~~
      |     m_vbox
../src/main.cpp:549:20: error: 'class Gtk::MessageDialog' has no member named 'get_vbox'
  549 |             mdiag->get_vbox()->pack_start( chk_button, Gtk::PACK_SHRINK );
      |                    ^~~~~~~~
../src/message/confirmdiag.cpp:26:5: error: 'get_vbox' was not declared in this scope
   26 |     get_vbox()->pack_start( *hbox, Gtk::PACK_SHRINK );
      |     ^~~~~~~~
../src/openurldiag.cpp:18:5: error: 'get_vbox' was not declared in this scope
   18 |     get_vbox()->pack_start( m_label_url, Gtk::PACK_SHRINK );
      |     ^~~~~~~~
../src/passwdpref.h:130:13: error: 'get_vbox' was not declared in this scope
  130 |             get_vbox()->pack_start( m_notebook );
      |             ^~~~~~~~

関連のissue: #229

GTK4で廃止される`Gtk::Dialog::get_vbox()`のかわりに
`Gtk::Dialog::get_content_area()`を使います。

非推奨のシンボルを無効化するマクロ
```
GDK_DISABLE_DEPRECATED
GTK_DISABLE_DEPRECATED
GDKMM_DISABLE_DEPRECATED
GTKMM_DISABLE_DEPRECATED
GIOMM_DISABLE_DEPRECATED
GLIBMM_DISABLE_DEPRECATED
```

コンパイラのレポート
```
../src/control/mousekeypref.cpp:41:5: error: 'get_vbox' was not declared in this scope
   41 |     get_vbox()->pack_start( m_label );
      |     ^~~~~~~~
../src/control/mousekeypref.cpp:301:5: error: 'get_vbox' was not declared in this scope
  301 |     get_vbox()->set_spacing( 8 );
      |     ^~~~~~~~
../src/control/mousekeypref.cpp:532:5: error: 'get_vbox' was not declared in this scope
  532 |     get_vbox()->set_spacing( 8 );
      |     ^~~~~~~~
../src/dbimg/delimgcachediag.cpp:34:5: error: 'get_vbox' was not declared in this scope
   34 |     get_vbox()->set_spacing( mrg );
      |     ^~~~~~~~
../src/dbimg/delimgdiag.h:110:13: error: 'get_vbox' was not declared in this scope
  110 |             get_vbox()->set_spacing( 8 );
      |             ^~~~~~~~
../src/fontcolorpref.cpp:241:5: error: 'get_vbox' was not declared in this scope
  241 |     get_vbox()->pack_start( m_notebook );
      |     ^~~~~~~~
../src/globalabonepref.h:73:13: error: 'get_vbox' was not declared in this scope
   73 |             get_vbox()->pack_start( m_notebook );
      |             ^~~~~~~~
../src/globalabonethreadpref.h:116:13: error: 'get_vbox' was not declared in this scope
  116 |             get_vbox()->pack_start( m_notebook );
      |             ^~~~~~~~
../src/image/preference.cpp:76:5: error: 'get_vbox' was not declared in this scope
   76 |     get_vbox()->pack_start( m_vbox_info );
      |     ^~~~~~~~
../src/linkfilterpref.cpp:47:5: error: 'get_vbox' was not declared in this scope; did you mean 'm_vbox'?
   47 |     get_vbox()->set_spacing( 8 );
      |     ^~~~~~~~
      |     m_vbox
../src/linkfilterpref.cpp:113:5: error: 'get_vbox' was not declared in this scope
  113 |     get_vbox()->set_spacing( 8 );
      |     ^~~~~~~~
../src/livepref.cpp:66:5: error: 'get_vbox' was not declared in this scope; did you mean 'm_vbox'?
   66 |     get_vbox()->set_spacing( mrg );
      |     ^~~~~~~~
      |     m_vbox
../src/main.cpp:549:20: error: 'class Gtk::MessageDialog' has no member named 'get_vbox'
  549 |             mdiag->get_vbox()->pack_start( chk_button, Gtk::PACK_SHRINK );
      |                    ^~~~~~~~
../src/message/confirmdiag.cpp:26:5: error: 'get_vbox' was not declared in this scope
   26 |     get_vbox()->pack_start( *hbox, Gtk::PACK_SHRINK );
      |     ^~~~~~~~
../src/openurldiag.cpp:18:5: error: 'get_vbox' was not declared in this scope
   18 |     get_vbox()->pack_start( m_label_url, Gtk::PACK_SHRINK );
      |     ^~~~~~~~
../src/passwdpref.h:130:13: error: 'get_vbox' was not declared in this scope
  130 |             get_vbox()->pack_start( m_notebook );
      |             ^~~~~~~~
```
@ma8ma ma8ma added gtk3 GTK3版に関するトピック refactoring コードの整理 (バグ修正でも機能変更でもない) labels Sep 19, 2020
@ma8ma ma8ma added this to In progress in State of JDim-v0.4.0+ via automation Sep 19, 2020
@ma8ma ma8ma merged commit 52752c1 into JDimproved:master Sep 19, 2020
State of JDim-v0.4.0+ automation moved this from In progress to Done Sep 19, 2020
@ma8ma ma8ma deleted the use-gtkdialog-get_content_area-instead-of-get_vbox-part2 branch September 19, 2020 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gtk3 GTK3版に関するトピック refactoring コードの整理 (バグ修正でも機能変更でもない)
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant