setupwizard: Use Gtk::Grid instead of Gtk::Table #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GTK4で廃止される`Gtk::Table`のかわりに`Gtk::Grid`を使います。
非推奨のシンボルを無効化するマクロ
```
GDK_DISABLE_DEPRECATED
GTK_DISABLE_DEPRECATED
GDKMM_DISABLE_DEPRECATED
GTKMM_DISABLE_DEPRECATED
GIOMM_DISABLE_DEPRECATED
GLIBMM_DISABLE_DEPRECATED
```
コンパイラのレポート
```
../src/setupwizard.h:73:14: error: 'Table' in namespace 'Gtk' does not name a type
73 | Gtk::Table m_table;
| ^~~~~
```
ma8ma
commented
Sep 26, 2020
Comment on lines
+146
to
+156
| constexpr int width = 1; | ||
| constexpr int height = 1; | ||
| m_table.attach( m_label_res, 0, 0, width, height ); | ||
| m_table.attach( m_label_mail, 0, 1, width, height ); | ||
| m_table.attach( m_label_popup, 0, 2, width, height ); | ||
| m_table.attach( m_label_tree, 0, 3, width, height ); | ||
|
|
||
| m_table.attach( m_font_res, 1, 0, width, height ); | ||
| m_table.attach( m_font_mail, 1, 1, width, height ); | ||
| m_table.attach( m_font_popup, 1, 2, width, height ); | ||
| m_table.attach( m_font_tree, 1, 3, width, height ); |
There was a problem hiding this comment.
コンパイルエラーの原因 (https://github.com/JDimproved/JDim/runs/1169393326)
gtkmm 3.22 の Gtk::Grid::attach() にはデフォルト引数が設定されていない。
https://developer.gnome.org/gtkmm/3.22/classGtk_1_1Grid.html#a9c425e95660daff60a77fc0cafc18115
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GTK4で廃止される
Gtk::TableのかわりにGtk::Gridを使います。非推奨のシンボルを無効化するマクロ
コンパイラのレポート
関連のissue: #229