font.cpp内のmallocをnewに置き換える #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
現在font.cpp内ではmalloc()によって確保したポインタをdeleteで削除しています。 これは未定義動作になるので、代わりにnewを使うように変更し、同時にmemsetによるゼロフィルをリスト初期化に置き換えます。 また現在g++による警告(type qualifiers ignored on cast result type)が出ているため不要なconstを取り除きます。
|
ありがとうございます |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
現在font.cpp内ではmalloc()によって確保したポインタをdeleteで削除しています。
これは未定義動作になるので、代わりにnewを使うように変更し、同時にmemsetによるゼロフィルをリスト初期化に置き換えます。
また現在g++による警告(type qualifiers ignored on cast result type)が出ているため不要なconstを取り除きます。