Use i18n text instead of Gtk::Stock::(ADD|DELETE) for button label #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GTK4で廃止される`Gtk::Stock::(ADD|DELETE)`をi18n対応テキストに置き換えます。 Gtk::Stockからラベルに変更する参考文献: https://developer.gnome.org/gtk3/stable/gtk3-Stock-Items.html https://stackoverflow.com/questions/36805505/gtk-stock-is-deprecated-whats-the-alternative/36811163#36811163 https://gitlab.gnome.org/GNOME/gtk/blob/3.24.20/gtk/deprecated/gtkstock.c#L346 非推奨のシンボルを無効化するマクロ ``` GDK_DISABLE_DEPRECATED GTK_DISABLE_DEPRECATED GDKMM_DISABLE_DEPRECATED GTKMM_DISABLE_DEPRECATED GIOMM_DISABLE_DEPRECATED GLIBMM_DISABLE_DEPRECATED ``` コンパイラのレポート ``` ../src/control/mousekeypref.cpp:272:29: error: 'Gtk::Stock' has not been declared 272 | m_button_delete( Gtk::Stock::DELETE ), | ^~~~~ ../src/control/mousekeypref.cpp:273:26: error: 'Gtk::Stock' has not been declared 273 | m_button_add( Gtk::Stock::ADD ), | ^~~~~ ../src/linkfilterpref.cpp:70:29: error: 'Gtk::Stock' has not been declared 70 | m_button_delete( Gtk::Stock::DELETE ), | ^~~~~ ../src/linkfilterpref.cpp:71:26: error: 'Gtk::Stock' has not been declared 71 | m_button_add( Gtk::Stock::ADD ) | ^~~~~ ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GTK4で廃止される
Gtk::Stock::(ADD|DELETE)をi18n対応テキストに置き換えます。Gtk::Stockからラベルに変更する参考文献
https://developer.gnome.org/gtk3/stable/gtk3-Stock-Items.html
https://stackoverflow.com/questions/36805505/gtk-stock-is-deprecated-whats-the-alternative/36811163#36811163
https://gitlab.gnome.org/GNOME/gtk/blob/3.24.20/gtk/deprecated/gtkstock.c#L346
非推奨のシンボルを無効化するマクロ
コンパイラのレポート
関連のissue: #229, #482