misctrip: Add configure check for thread-safe crypt_r #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`crypt`関数のスレッドセーフなバージョンが使える環境では`crypt_r`を 使うように変更します。
ma8ma
commented
May 15, 2021
| @@ -147,7 +147,13 @@ std::string create_trip_newtype( const std::string& key ) | |||
| salt.append( ".." ); | |||
|
|
|||
| // crypt (key は先頭8文字しか使われない) | |||
| const char *crypted = crypt( key_binary, salt.c_str() ); | |||
| #ifdef HAVE_CRYPT_R | |||
There was a problem hiding this comment.
minefieldブランチでは_GNU_SOURCEマクロで条件コンパイルを設けてますがFreeBSDでも利用できる関数なのでconfigureチェックで確認します。
|
https://github.com/JDimproved/JDim/pull/724/checks?check_run_id=2589486392 masterブランチでテスト成功するか確認します |
2021-05-15のPull RequestでUbuntu 20.04で行うclang-9を使ったテストが SIGABRTで失敗しました。[*] そのためclang-9のテストをUbuntu 18.04で行う ようにCI設定を変更します。 [*]: https://github.com/JDimproved/JDim/pull/724/checks?check_run_id=2589486392
|
https://github.com/JDimproved/JDim/runs/2589523269?check_suite_focus=true masterブランチの再テストでも同じくSIGABRTで失敗したためclang-9のテストを実行するディストロをUbuntu 18.04に変えて試してみます。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crypt関数のスレッドセーフなバージョンが使える環境ではcrypt_rを使うように変更します。参考文献