Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeTreeBase: Add static keyword to member function #729

Merged

Conversation

ma8ma
Copy link
Collaborator

@ma8ma ma8ma commented May 16, 2021

メンバー変数やメンバー関数を使用しないメンバー関数を静的メンバーにして保守性を向上させます。

  • NodeTreeBase::remove_imenu()
  • NodeTreeBase::convert_amp()

メンバー変数やメンバー関数を使用しないメンバー関数を
静的メンバーにして保守性を向上させます。

- `NodeTreeBase::remove_imenu()`
- `NodeTreeBase::convert_amp()`
@ma8ma ma8ma added the refactoring コードの整理 (バグ修正でも機能変更でもない) label May 16, 2021
@ma8ma ma8ma added this to In progress in State of JDim-v0.5.0+ via automation May 16, 2021
@ma8ma ma8ma closed this May 16, 2021
State of JDim-v0.5.0+ automation moved this from In progress to Done May 16, 2021
@ma8ma
Copy link
Collaborator Author

ma8ma commented May 16, 2021

ActionsがQueuedから動いてません

edit: githubが調査しています
https://www.githubstatus.com/incidents/zbpwygxwb3gw

@ma8ma ma8ma reopened this May 16, 2021
State of JDim-v0.5.0+ automation moved this from Done to In progress May 16, 2021
@ma8ma ma8ma merged commit 64c80a9 into JDimproved:master May 17, 2021
State of JDim-v0.5.0+ automation moved this from In progress to Done May 17, 2021
@ma8ma ma8ma deleted the nodetreebase-add-static-keyword-member-function branch May 17, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring コードの整理 (バグ修正でも機能変更でもない)
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant