Add thread abone config for low number of res #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
板にある未取得スレッドの内、nレス以下のものをあぼ〜んにする機能を追加 します。また、設定の上限を定数から最大表示可能レス数の値に変更します。 元となった玉葱版パッチを元に改変しています。 設定ファイルのnレス以下の項目は名前を変更したため互換性がありません。 - abone_min_number_thread -> abone_low_number_thread - aboneminnumberthread -> abonelownumberthread Co-authored-by: JD Project <jd.project@acc574344b8506f1335297eaa7f74be0f7ea992b>
ma8ma
commented
Oct 2, 2021
| @@ -2962,10 +2962,11 @@ void BoardViewBase::slot_abone_thread() | |||
| // あぼーん情報更新 | |||
| std::list< std::string > words = DBTREE::get_abone_list_word_thread( get_url_board() ); | |||
| std::list< std::string > regexs = DBTREE::get_abone_list_regex_thread( get_url_board() ); | |||
| const int number = DBTREE::get_abone_number_thread( get_url_board() ); | |||
| const int low_number = DBTREE::get_abone_low_number_thread( get_url_board() ); | |||
| const int high_number = DBTREE::get_abone_high_number_thread( get_url_board() ); | |||
There was a problem hiding this comment.
元のパッチは設定名にmin, maxを使っていますがlow, highに置き換えています。
- 長い識別子の中で違いがmxxの2文字しかなく読みづらい
- 機能(nレス以下、nレス以上)に対して最小、最大の語句は内容を言い表せてないと感じる
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
板にある未取得スレッドの内、nレス以下のものをあぼ〜んにする機能を追加します。
また、設定の上限を定数から最大表示可能レス数の値に変更します。
元となった玉葱版パッチを元に改変しています。
設定ファイルのnレス以下の項目は名前を変更したため互換性がありません。
abone_min_number_thread->abone_low_number_threadaboneminnumberthread->abonelownumberthread関連のissue: #76