Improve named color support for jd.css #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
スタイルシート(`jd.css`)によるスレビューのカスタマイズを更新して サポートする色キーワード[*]を追加します。 - 色のプロパティ値は大文字小文字を区別しません。 - 色キーワードにCSS2.1, CSS3, CSS4の対応を追加します。 実装の詳細 webブラウザと異なり未知のキーワードや不正な値は変換して扱われます。 [*]: https://developer.mozilla.org/ja/docs/Web/CSS/color_value#color_keywords Co-authored-by: JD Project <jd.project@acc574344b8506f1335297eaa7f74be0f7ea992b>
`std::find_if()`による線形探索のかわりの文字列の辞書順ソートを利用した 二分探索に変更して検索効率を改善します。
ma8ma
force-pushed
the
improve-named-color-support-for-jdcss
branch
from
93ed39d
to
9d59274
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve named color support for jd.css
スタイルシート(
jd.css)によるスレビューのカスタマイズを更新してサポートする色キーワードを追加します。実装の詳細
webブラウザと異なり未知のキーワードや不正な値は変換して扱われます。
miscgtk: Use std::lower_bound() to search named color
std::find_if()による線形探索のかわりの文字列の辞書順ソートを利用した二分探索に変更して検索効率を改善します。関連のissue: #76