Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EditTreeView: Add const qualifier to function parameter #873

Conversation

ma8ma
Copy link
Collaborator

@ma8ma ma8ma commented Dec 5, 2021

メンバー関数の引数にconstを付けれるとcppcheck 2.6.2に指摘されたため修正します。

cppcheckのレポート

src/skeleton/edittreeview.cpp:1110:61: style: Parameter 'list_path' can be declared with const [constParameter]
void EditTreeView::delete_path( std::list< Gtk::TreePath >& list_path, const bool force )
                                                            ^

関連のpull request: #865

メンバー関数の引数にconstを付けれるとcppcheck 2.6.2に指摘されたため
修正します。

cppcheckのレポート
```
src/skeleton/edittreeview.cpp:1110:61: style: Parameter 'list_path' can be declared with const [constParameter]
void EditTreeView::delete_path( std::list< Gtk::TreePath >& list_path, const bool force )
                                                            ^
```
@ma8ma ma8ma added the refactoring コードの整理 (バグ修正でも機能変更でもない) label Dec 5, 2021
@ma8ma ma8ma added this to In progress in State of JDim-v0.6.0+ via automation Dec 5, 2021
@ma8ma ma8ma merged commit 8fb0988 into JDimproved:master Dec 5, 2021
State of JDim-v0.6.0+ automation moved this from In progress to Done Dec 5, 2021
@ma8ma ma8ma deleted the edittreeview-add-const-qualfier-to-function-param branch December 5, 2021 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring コードの整理 (バグ修正でも機能変更でもない)
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant