Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miscutil: Fix percent encoding to use uppercase #885

Merged

Conversation

ma8ma
Copy link
Collaborator

@ma8ma ma8ma commented Dec 22, 2021

文字列をパーセントエンコーディングに変換する処理で16進数表記のA-Fを小文字から大文字に変更します。
RFC3986では大文字を使うべきと書かれています。

For consistency, URI producers and normalizers should use uppercase hexadecimal digits for all percent-encodings.

修正にあたり不具合報告をしていただきありがとうございました。
https://next2ch.net/test/read.cgi/linux/1613035222/557
https://mao.5ch.net/test/read.cgi/linux/1615781919/869

文字列をパーセントエンコーディングに変換する処理で16進数表記のA-Fを
小文字から大文字に変更します。RFC3986[1]では大文字を使うべきと
書かれています。

> For consistency, URI producers and normalizers should use uppercase
> hexadecimal digits for all percent-encodings.

修正にあたり不具合報告をしていただきありがとうございました。
https://next2ch.net/test/read.cgi/linux/1613035222/557
https://mao.5ch.net/test/read.cgi/linux/1615781919/869

[1]: https://datatracker.ietf.org/doc/html/rfc3986#section-2.1
@ma8ma ma8ma added the bug バグの追跡 label Dec 22, 2021
@ma8ma ma8ma added this to In progress in State of JDim-v0.6.0+ via automation Dec 22, 2021
@ma8ma ma8ma merged commit 45202ac into JDimproved:master Dec 22, 2021
State of JDim-v0.6.0+ automation moved this from In progress to Done Dec 22, 2021
@ma8ma ma8ma deleted the miscutil-fix-percent-encoding-to-use-uppercase branch December 22, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug バグの追跡
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant