Update function MISC::is_euc() to MISC::is_eucjp() #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
関数名をより正確に変更します。また、引数を更新して処理を効率化します。 追加された長さチェックはヌル終端の保証がある `const std::string&`なら 不要ですが他の`is_*`関数との一貫性のため`std::string_view`を使います。
This was referenced May 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test cases for MISC::is_euc()
Update function MISC::is_euc() to MISC::is_eucjp()
関数名をより正確に変更します。また、引数を更新して処理を効率化します。
追加された長さチェックはヌル終端の保証がある
const std::string&なら不要ですが他のis_*関数との一貫性のためstd::string_viewを使います。