Skip to content

Commit

Permalink
require 'rake/rdoctask' if failed to require 'rdoc/task'
Browse files Browse the repository at this point in the history
fixes a regression introduced by b921679
require 'rdoc/task' fails if the system RDoc version is below 2.4.2 (e.g. CRuby 1.8.7)
  • Loading branch information
amatsuda committed May 25, 2011
1 parent 41eac9b commit 24b28a2
Show file tree
Hide file tree
Showing 5 changed files with 27 additions and 6 deletions.
7 changes: 6 additions & 1 deletion Rakefile
@@ -1,6 +1,11 @@
#!/usr/bin/env rake

require 'rdoc/task'

begin
require 'rdoc/task'
rescue LoadError
require 'rake/rdoctask'
end
require 'net/http'

$:.unshift File.expand_path('..', __FILE__)
Expand Down
Expand Up @@ -4,8 +4,11 @@ begin
rescue LoadError
puts 'You must `gem install bundler` and `bundle install` to run rake tasks'
end

require 'rdoc/task'
begin
require 'rdoc/task'
rescue LoadError
require 'rake/rdoctask'
end

RDoc::Task.new(:rdoc) do |rdoc|
rdoc.rdoc_dir = 'rdoc'
Expand Down
6 changes: 5 additions & 1 deletion railties/lib/rails/tasks/documentation.rake
@@ -1,4 +1,8 @@
require 'rdoc/task'
begin
require 'rdoc/task'
rescue LoadError
require 'rake/rdoctask'
end

# Monkey-patch to remove redoc'ing and clobber descriptions to cut down on rake -T noise
class RDocTaskWithoutDescriptions < RDoc::Task
Expand Down
7 changes: 6 additions & 1 deletion railties/test/railties/railtie_test.rb
Expand Up @@ -97,7 +97,12 @@ class MyTie < Rails::Railtie
assert !$ran_block
require 'rake'
require 'rake/testtask'
require 'rdoc/task'
begin
require 'rdoc/task'
rescue LoadError
require 'rake/rdoctask'
end


AppTemplate::Application.load_tasks
assert $ran_block
Expand Down
6 changes: 5 additions & 1 deletion railties/test/railties/shared_tests.rb
Expand Up @@ -237,7 +237,11 @@ def test_rake_tasks_lib_tasks_are_loaded

boot_rails
require 'rake'
require 'rdoc/task'
begin
require 'rdoc/task'
rescue LoadError
require 'rake/rdoctask'
end
require 'rake/testtask'
Rails.application.load_tasks
Rake::Task[:foo].invoke
Expand Down

0 comments on commit 24b28a2

Please sign in to comment.