Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications : the last character of the message is ignored #109

Closed
JF002 opened this issue Oct 21, 2020 · 2 comments
Closed

Notifications : the last character of the message is ignored #109

JF002 opened this issue Oct 21, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@JF002
Copy link
Collaborator

JF002 commented Oct 21, 2020

The last character of the notification message is replaced by the trailing zero, and won't be displayed.
This led to the implementation of a workaround/hack in Gadgetbridge.
@JF002 JF002 mentioned this issue Oct 21, 2020
Merged
4 tasks
@JF002 JF002 added the bug Something isn't working label Oct 21, 2020
@JF002
Copy link
Collaborator Author

JF002 commented Oct 21, 2020

Fixed in 440ae41 (branch notification-ui). Not merged yet.

@JF002
Copy link
Collaborator Author

JF002 commented Oct 27, 2020

Merged in develop!

@JF002 JF002 closed this as completed Oct 27, 2020
azuwis pushed a commit to azuwis/Gadgetbridge that referenced this issue Nov 10, 2020
@JF002
Improve notification support for InfiniTime (PineTime) :
9d6ac2b 
 - InfiniTime 0.9 now supports messages up to 100 chars (instead of max 18 previously)
 - Remove the hack that was implemented as a workaround to a bug in InfiniTime that would ignore the last character of the notification message (InfiniTimeOrg/InfiniTime#109).

 These 2 features are enabled only if the firmware version is >= 0.9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JF002