dev_doeclim: a bug fix, const parameters, updated references #211
Conversation
Forgot to add the factor for the slightly smaller surface area of the interior ocean
includes full citations and the fact that we have permission.
set hard-coded DOECLIM parameters to const; moved their initializations to the header. if these initializations are static I get a warning, so just const for now.
bvegawe
changed the title
| @@ -7,9 +7,6 @@ | |||
| objects = { | |||
There was a problem hiding this comment.
You probably should. Windows users will need it in order to build the code, so it's best if it comes in the package.
|
@cahartin Hmm, actually I was previously testing this on my mac using xcode. When I now try to build on linux (using |
|
@bvegawe did you try make clean? and then what compiler are you using? did that change? |
|
I guess the error depends on the version of gcc. My local cluster default is 4.4.7. When I switch to 6.1.0, the error goes away. Do you think that version sensitivity is a problem? |
|
Yea, we make sure to always load 6.1.0 when running GCAM/Hector. I don't know why but I think it might have to do with the libraries etc. |
|
Ah ok; I'll do the same from now on. |
Bug fix in total heat flux calculation. Improved DOECLIM references. Made some parameters const and moved their assignment to the header.