Interpolation fix #646
Merged
Interpolation fix #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove old `ffi()`, etc. functions; see #643
Closed
|
Graph out to 2300
|
kdorheim
approved these changes
Nov 1, 2022
| @@ -31,7 +31,7 @@ find ./inst/input -name "*.ini" -print0 | xargs -0 -n1 $HECTOR | |||
|
|
|||
| # Make sure the model handles year changes | |||
| echo "---------- Running: year changes ----------" | |||
| sed 's/startDate=1745/startDate=1740/' $INPUT/hector_ssp245.ini > $INPUT/hector_ssp245_time.ini | |||
| sed 's/startDate=1745/startDate=1746/' $INPUT/hector_ssp245.ini > $INPUT/hector_ssp245_time.ini | |||
There was a problem hiding this comment.
Why is it 1746 instead of 1745?
There was a problem hiding this comment.
The test used to change 1745 to 1740, but now that interpolation is disallowed we have to use a year that appears in the emissions inputs (or else the test bombs with an "interpolation not allowed" error). So changed to 1746.
There was a problem hiding this comment.
Gottcha that makes sense thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK #639 has too many changes in it to unambiguously evaluate model behavior changes, so:
This PR isolates the issue we know we need to fix — #643 . Basically, the interpolated nature of the LUC emissions and uptake time series means that we can emit or take up more/less than specified by the input data.
NOTE: currently both the old-new test (to easily see errors) and the post-LUC-pulse test (because not taking out C proportionately) are disabled.
The former needs to be re-enabled before merging.