Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRD-52/Altium-GND-symbol #480

Closed
wants to merge 1 commit into from
Closed

PRD-52/Altium-GND-symbol #480

wants to merge 1 commit into from

Conversation

erwin-lau
Copy link
Contributor

  • use JITX symbol for Altium GND in (tick)altium backend.
  • Altium export will still shown Altium GND.
    image

Copy link

linear bot commented Mar 29, 2024

@ariel-hi
Copy link
Contributor

This change has a few ramifications on the internal design flow.

If the Altium GND symbol is changed in JITX, this means we no longer need to keep any of the Altium-specific pcb-symbols in sync with how they appear in Altium.

We have a step in our workflow where symbols are substituted to Kicad or Altium form. I expect that substitution is no longer necessary.

@d-haldane
Copy link
Contributor

This is not the right fix for this problem. The issue was with ground-sym the JITX schematic visualizer ignores the graphical information in ground-sym and incorrectly shows the backend-subsitution symbol instead.

It needs to show the geometry in ground-sym.

@erwin-lau
Copy link
Contributor Author

We have a step in our workflow where symbols are substituted to Kicad or Altium form. I expect that substitution is no longer necessary.

If we eliminate substitution, at what point Altium knows the symbol needs to rotate 90 degrees clockwise to point downward?

@erwin-lau
Copy link
Contributor Author

This is not the right fix for this problem. The issue was with ground-sym the JITX schematic visualizer ignores the graphical information in ground-sym and incorrectly shows the backend-substitution symbol instead.

It needs to show the geometry in ground-sym.

I believe the whole purpose of backend-substitution is to show what user should see in the selected CAD tool when it is exported. That is why the Altium ground symbol is a bit bigger because it is how it is drawn in Altium. This cannot be altered. Thus we mock Altium's drawing in our own form.

If we skip backend-substitution in JITX-visualizer we need to replace it with a step in exporter to rotate the ground symbol 90 degrees clockwise (and power symbols CCW) because all net-symbols in Altium point to the right.
There is another risk. Since the JITX-ground-symbol is smaller, it is possible to have overlapped drawings when the schematic is exported. (see the exported picture above, right). I am not sure if we have a mechanism to assign larger symbol bounds instead of calculates it to avoid potential overlapping.

@erwin-lau
Copy link
Contributor Author

Withdraw this until we have a better solution.

@erwin-lau erwin-lau closed this Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants