Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Armor does not interact with player hitboxes correctly #286

Open
Silverfang22 opened this issue Jan 7, 2018 · 6 comments
Open

Armor does not interact with player hitboxes correctly #286

Silverfang22 opened this issue Jan 7, 2018 · 6 comments
Labels
bug Doesn't work as intended. priority:high Fix first.

Comments

@Silverfang22
Copy link
Member

As reported by Futuza, leg armor is providing some protection to torso, and torso armor is only providing protection to very small areas around the center of the stomach and chest.

I'm not sure the player hitbox for these areas should exist at all or it should be ignored? Maybe the player hitbox is "clipping" through the armor hitbox and is being hit more often than the armor hitbox?

@Silverfang22 Silverfang22 added bug Doesn't work as intended. priority:high Fix first. labels Jan 7, 2018
@Silverfang22 Silverfang22 added this to the Versus Revision 3 milestone Jan 7, 2018
@Silverfang22
Copy link
Member Author

@DarthFutuza
Copy link
Member

Additionally leg armor is weirdly protecting non leg areas, like parts of the torso.

@gyurka66
Copy link

Why does armor have a hitbox at all? wouldn't it be eaiser if armor just reduced damage for the limb it's equipped on?

@DarthFutuza
Copy link
Member

Why does armor have a hitbox at all? wouldn't it be eaiser if armor just reduced damage for the limb it's equipped on?

That's actually what it does, "hitbox" is a bit of a misnomer. Its supposed to be handled the same way limb damage calculation is, but there's something off/not being applied right. That said, there might be some issues if armor doesn't actually have a hitbox, since for example if you made an armor that was really big like a hazardtrooper armor, it needs to expand/change the player's hitbox among other things.

@gyurka66
Copy link

gyurka66 commented Jan 21, 2021

it needs to expand/change the player's hitbox among other things.

how feastible would it be to completely replace the torso / limb model with the armor. Like how the character editor changes the model?

@DarthFutuza
Copy link
Member

I'll have to look at it closer as I'm not sure. It turns off the underlying model and replaces it with the armor at least visually, just not sure if it does that with hitboxes/physics etc too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Doesn't work as intended. priority:high Fix first.
Projects
None yet
Development

No branches or pull requests

3 participants