Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multicast option to request node #24

Merged
merged 3 commits into from
Feb 26, 2021
Merged

Add multicast option to request node #24

merged 3 commits into from
Feb 26, 2021

Conversation

JKRhb
Copy link
Owner

@JKRhb JKRhb commented Feb 20, 2021

This PR adds a multicast option to the request node. Before, it was not possible to perform actual multicast requests as the underlying node-coap package requires this option to be set in requests to do so. The PR is still WIP as new unit tests and the possibility to set the multicast timeout are still missing.

@coveralls
Copy link

coveralls commented Feb 20, 2021

Pull Request Test Coverage Report for Build 603686128

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 90.96%

Totals Coverage Status
Change from base Build 603403890: 0.2%
Covered Lines: 117
Relevant Lines: 126

💛 - Coveralls

@JKRhb JKRhb merged commit 7324e7f into master Feb 26, 2021
@JKRhb JKRhb deleted the multicast-option branch February 26, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants