Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CoAP response node #27

Merged
merged 4 commits into from
Apr 3, 2022
Merged

Add a CoAP response node #27

merged 4 commits into from
Apr 3, 2022

Conversation

JKRhb
Copy link
Owner

@JKRhb JKRhb commented Mar 15, 2021

This PR will add a reponse node to the package that is similar to the HTTP response node in the core package.

At the moment, as it was discussed in issue #14, sending an actual response after an incoming request requires a function node which calls msg.res.end() which is rather unintuitive. Having a dedicated reponse node will make flows more easy to understand. It will also enable the package to implement more features from the specifications, for example the handling of different media types and options from requests.

This PR is still WIP. Once it is finished it will resolve #20.

@JKRhb JKRhb self-assigned this Mar 15, 2021
@coveralls
Copy link

coveralls commented Mar 15, 2021

Pull Request Test Coverage Report for Build 2085815430

  • 45 of 62 (72.58%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-9.8%) to 80.08%

Changes Missing Coverage Covered Lines Changed/Added Lines %
coap/coap-in.js 45 62 72.58%
Totals Coverage Status
Change from base Build 2082357389: -9.8%
Covered Lines: 140
Relevant Lines: 167

💛 - Coveralls

@JKRhb JKRhb mentioned this pull request Mar 16, 2021
@JKRhb JKRhb force-pushed the coap-response branch 5 times, most recently from d0bd4f8 to 708b1e7 Compare September 20, 2021 19:03
@JKRhb JKRhb force-pushed the coap-response branch 4 times, most recently from f69ad1e to f3f4dad Compare April 3, 2022 15:58
@JKRhb JKRhb merged commit 1e0a81e into master Apr 3, 2022
@JKRhb JKRhb deleted the coap-response branch April 3, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add coap response node
2 participants