fix typings and simlify booleanify

JLHwung · May 17, 2024 · a6ca1cb · a6ca1cb
1 parent 6f6877c
commit a6ca1cb
Showing 1 changed file with 6 additions and 9 deletions.
diff --git a/packages/babel-cli/src/babel/options.ts b/packages/babel-cli/src/babel/options.ts
@@ -364,18 +364,15 @@ export default function parseArgv(args: Array<string>): CmdOptions | null {
   };
 }
 
-function booleanify(val: "false" | 0 | ""): false;
-function booleanify(val: "true" | 1): true;
-function booleanify(val: any): any {
-  if (val === undefined) return undefined;
-
-  // eslint-disable-next-line eqeqeq
-  if (val === "true" || val == 1) {
+function booleanify(val: "false" | "0" | ""): false;
+function booleanify(val: "true" | "1"): true;
+function booleanify(val: string): boolean | string {
+  if (val === "true" || val === "1") {
     return true;
   }
 
-  // eslint-disable-next-line eqeqeq
-  if (val === "false" || val == 0 || !val) {
+  // false for --opt=false; 0 for --opt=0 or --opt 0; "" for --opt=
+  if (val === "false" || val === "0" || val === "") {
     return false;
   }