Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure configuration cache is supported #364

Closed
ZakTaccardi opened this issue Jul 6, 2020 · 4 comments
Closed

Ensure configuration cache is supported #364

ZakTaccardi opened this issue Jul 6, 2020 · 4 comments

Comments

@ZakTaccardi
Copy link

Gradle has a new feature called the Configuration Cache. It was previously known as Instant Execution, and this greatly improves build speed.

Usage of the Configuration Cache has a stricter list of requirements.

While the this plugin may already be compatible with the Configuration Cache, please investigate this to ensure support.

See gradle/gradle#13490 for a list of all community plugins and whether they support the configuration cache.

@JLLeitschuh
Copy link
Owner

@ZakTaccardi Do you have the cycles to perform this exploration? A test that verifies compatibility with the configuration cache would be appreciated.

@ZakTaccardi
Copy link
Author

ZakTaccardi commented Jul 6, 2020

Check out this issue

michel-kraemer/gradle-download-task#156

@eskatos I'm not sure how to generate the problems report - may be useful to include that in the example issue

It looks like if you enable the configuration cache, the build will automatically fail if issues are encountered.

There's also flags for ignoring configuration cache issues or issuing warnings

https://docs.gradle.org/nightly/userguide/configuration_cache.html#config_cache:usage:ignore_problems

@eskatos is there currently a way to test or set a plugin specific flag to ensure (fail the build) if only the plugin you are authoring violates the configuration cache rules? I would imagine many plugins may rely on other plugins that do not support the configuration cache yet (like the Kotlin Gradle plugin), but would want to fail the build if the plugin that is being authored breaks configuration cache rules

@eskatos
Copy link
Contributor

eskatos commented Jul 7, 2020

@JLLeitschuh testing for the configuration cache is documented at https://docs.gradle.org/nightly/userguide/configuration_cache.html#config_cache:testing

@ZakTaccardi the report is generated as soon as at least one problem is detected. There's currently no way to filter problems by provenance.

JLLeitschuh added a commit that referenced this issue Jul 8, 2020
JLLeitschuh added a commit that referenced this issue Jul 8, 2020
JLLeitschuh added a commit that referenced this issue Jul 9, 2020
JLLeitschuh added a commit that referenced this issue Jul 9, 2020
@JLLeitschuh
Copy link
Owner

@ZakTaccardi let us know if you have additional issues with this. The Kotlin plugin is the biggest limiter here for supporting the configuration cache for this plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants