define a different output file for each sourceSet #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting. Can you update the changelog to reflect this and I'll merge it? |
|
You should wait to do anything on this regarding the changelog until after #20 is merged so you won't have to deal with merge conflicts. |
lampietti
force-pushed
the
reportsFilename
branch
from
a2e1a5a
to
6de0a98
Compare
|
Welp, I totally dropped the ball on merging this one. Sorry about that. |
lampietti
force-pushed
the
reportsFilename
branch
3 times, most recently
from
f1fdba5
to
06129f6
Compare
While the ktlint checkstyle reporter stream Strings in output file, it generates a corrupted XML after the first sourceSet run
lampietti
force-pushed
the
reportsFilename
branch
from
06129f6
to
bd23607
Compare
|
@JLLeitschuh ready to be merged |
|
Thanks! |
|
Great work! Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the ktlint checkstyle reporter stream Strings in output file, it generates a corrupted XML after the first sourceSet run.
Fix-it by generating one file by sourceSet, with the following naming:
ktlint-${sourceSetName}.${extension.reporter.fileExtension}