Allow to override generated reports base directory. #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tapchicoma
force-pushed
the
expose_output_file
branch
2 times, most recently
from
9cc68c3
to
df8f809
Compare
JLLeitschuh
reviewed
Mar 9, 2020
Comment on lines
47
to
49
| * [DirectoryProperty] takes into account also content of directory, when snapshotting input. | ||
| * As reports generated are always generated in this directory, this prevents task proper caching, | ||
| * so this input exists as a workaround for the described problem. |
There was a problem hiding this comment.
Can you elaborate? I'm missing something.
There was a problem hiding this comment.
Task caching also snapshots the outputs. If the output has changed, the task is marked as out of date. Why do we need this?
There was a problem hiding this comment.
You are right, was confused by https://docs.gradle.org/current/javadoc/org/gradle/api/tasks/InputDirectory.html. Actually reporterOutputDir could be just annotated with @get:Input.
There was a problem hiding this comment.
Force updated and removed this property.
There was a problem hiding this comment.
or not... running tests in IDEA was green, though from command line they fail 🤔
There was a problem hiding this comment.
Should be fine now
Tapchicoma
force-pushed
the
expose_output_file
branch
from
df8f809
to
3c2a68e
Compare
Tapchicoma
force-pushed
the
expose_output_file
branch
from
3c2a68e
to
afe25db
Compare
Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com>
Tapchicoma
force-pushed
the
expose_output_file
branch
from
0f9b95b
to
ec58992
Compare
JLLeitschuh
reviewed
Jul 17, 2020
Co-authored-by: Jonathan Leitschuh <jonathan.leitschuh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #321