Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ktlint to 0.40.0. #421

Merged
merged 3 commits into from
Feb 8, 2021
Merged

Conversation

utwyko
Copy link
Contributor

@utwyko utwyko commented Dec 20, 2020

@JLLeitschuh
Copy link
Owner

Looks like this change introduces some test failures. PTAL

@utwyko
Copy link
Contributor Author

utwyko commented Dec 22, 2020

Looks like this change introduces some test failures. PTAL

Huh seems I ran the tests incorrectly locally before pushing. I'll take a look later this week!

@utwyko
Copy link
Contributor Author

utwyko commented Dec 27, 2020

Tests are failing due to pinterest/ktlint#997. Will update this PR when a version of ktlint is released including that fix.

@Tapchicoma
Copy link
Collaborator

Probably better to add empty .editorconfig then to wait for a new release.

@Tapchicoma Tapchicoma merged commit 864685e into JLLeitschuh:master Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants