add tests to prove fix for #627 #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wakingrufus
force-pushed
the
test-ec-disabled-old
branch
2 times, most recently
from
e1be5bc
to
267a302
Compare
stkent
reviewed
Feb 9, 2023
plugin/src/test/kotlin/org/jlleitschuh/gradle/ktlint/DisabledRulesTest.kt
Outdated
Show resolved
Hide resolved
document proper disabled rules usage via tests
wakingrufus
force-pushed
the
test-ec-disabled-old
branch
from
267a302
to
3268ce4
Compare
stkent
approved these changes
Feb 9, 2023
| @@ -89,6 +110,7 @@ class DisabledRulesTest : AbstractPluginTest() { | |||
| build(CHECK_PARENT_TASK_NAME) { | |||
| assertThat(task(":$mainSourceSetCheckTaskName")?.outcome).isEqualTo(TaskOutcome.SUCCESS) | |||
| assertThat(output).doesNotContain("Property 'ktlint_disabled_rules' is deprecated") | |||
| assertThat(output).doesNotContain("Property 'disabled_rules' is deprecated") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.