Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ktlint and gradle versions for testing #632

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

wakingrufus
Copy link
Collaborator

add ktlint 0.48.2 to tested versions
update latest gradle to 7.6

}
buildAndFail(":some-module:$INSTALL_GIT_HOOK_FORMAT_TASK") {
assertThat(output).contains("Task '$INSTALL_GIT_HOOK_FORMAT_TASK' not found in project")
assertThat(output).containsIgnoringCase("Task '$INSTALL_GIT_HOOK_FORMAT_TASK' not found in project")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gradle 7.6 slightly changes this message

@wakingrufus wakingrufus marked this pull request as ready for review February 16, 2023 16:36
@Tapchicoma
Copy link
Collaborator

Error on Windows looks strage 🤔

# There is insufficient memory for the Java Runtime Environment to continue.
    # Native memory allocation (malloc) failed to allocate 32744 bytes for ChunkPool::allocate
    # An error report file with more information is saved as:
    # D:\a\ktlint-gradle\ktlint-gradle\plugin\.gradle-test-kit\workers\hs_err_pid7196.log
    #
    # Compiler replay data is saved as:
    # D:\a\ktlint-gradle\ktlint-gradle\plugin\.gradle-test-kit\workers\replay_pid7196.log
    Unexpected exception thrown.
    org.gradle.internal.remote.internal.MessageIOException: Could not write '/127.0.0.1:60742'.
    	at org.gradle.internal.remote.internal.inet.SocketConnection.flush(SocketConnection.java:140)
    	at org.gradle.internal.remote.internal.hub.MessageHub$ConnectionDispatch.run(MessageHub.java:333)
    	at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:64)
    	at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:49)
    	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
    	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
    	at java.lang.Thread.run(Thread.java:750)
    Caused by: java.io.IOException: An existing connection was forcibly closed by the remote host
    	at sun.nio.ch.SocketDispatcher.write0(Native Method)
    	at sun.nio.ch.SocketDispatcher.write(SocketDispatcher.java:51)
    	at sun.nio.ch.IOUtil.writeFromNativeBuffer(IOUtil.java:93)
    	at sun.nio.ch.IOUtil.write(IOUtil.java:51)
    	at sun.nio.ch.SocketChannelImpl.write(SocketChannelImpl.java:470)
    	at org.gradle.internal.remote.internal.inet.SocketConnection$SocketOutputStream.writeWithNonBlockingRetry(SocketConnection.java:279)
    	at org.gradle.internal.remote.internal.inet.SocketConnection$SocketOutputStream.writeBufferToChannel(SocketConnection.java:267)
    	at org.gradle.internal.remote.internal.inet.SocketConnection$SocketOutputStream.flush(SocketConnection.java:261)
    	at org.gradle.internal.remote.internal.inet.SocketConnection.flush(SocketConnection.java:138)
    	... 6 more

@wakingrufus
Copy link
Collaborator Author

Error on Windows looks strage thinking

# There is insufficient memory for the Java Runtime Environment to continue.
    # Native memory allocation (malloc) failed to allocate 32744 bytes for ChunkPool::allocate
    # An error report file with more information is saved as:
    # D:\a\ktlint-gradle\ktlint-gradle\plugin\.gradle-test-kit\workers\hs_err_pid7196.log
    #
    # Compiler replay data is saved as:
    # D:\a\ktlint-gradle\ktlint-gradle\plugin\.gradle-test-kit\workers\replay_pid7196.log
    Unexpected exception thrown.
    org.gradle.internal.remote.internal.MessageIOException: Could not write '/127.0.0.1:60742'.
    	at org.gradle.internal.remote.internal.inet.SocketConnection.flush(SocketConnection.java:140)
    	at org.gradle.internal.remote.internal.hub.MessageHub$ConnectionDispatch.run(MessageHub.java:333)
    	at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:64)
    	at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:49)
    	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
    	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
    	at java.lang.Thread.run(Thread.java:750)
    Caused by: java.io.IOException: An existing connection was forcibly closed by the remote host
    	at sun.nio.ch.SocketDispatcher.write0(Native Method)
    	at sun.nio.ch.SocketDispatcher.write(SocketDispatcher.java:51)
    	at sun.nio.ch.IOUtil.writeFromNativeBuffer(IOUtil.java:93)
    	at sun.nio.ch.IOUtil.write(IOUtil.java:51)
    	at sun.nio.ch.SocketChannelImpl.write(SocketChannelImpl.java:470)
    	at org.gradle.internal.remote.internal.inet.SocketConnection$SocketOutputStream.writeWithNonBlockingRetry(SocketConnection.java:279)
    	at org.gradle.internal.remote.internal.inet.SocketConnection$SocketOutputStream.writeBufferToChannel(SocketConnection.java:267)
    	at org.gradle.internal.remote.internal.inet.SocketConnection$SocketOutputStream.flush(SocketConnection.java:261)
    	at org.gradle.internal.remote.internal.inet.SocketConnection.flush(SocketConnection.java:138)
    	... 6 more

Yeah this has been a known issue. we probably need to adjust the memory settings for the windows build, but haven't looked into it closely yet

add ktlint 0.48.2 to tested versions
update latest gradle to 7.6
@wakingrufus wakingrufus merged commit 1d63784 into main Feb 16, 2023
@wakingrufus wakingrufus deleted the ktlint-gradle-upgrades branch February 16, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants