Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix isRootEditorConfig #664

Merged
merged 1 commit into from
Apr 18, 2023
Merged

fix isRootEditorConfig #664

merged 1 commit into from
Apr 18, 2023

Conversation

wakingrufus
Copy link
Collaborator

fixes #575

JLLeitschuh
JLLeitschuh approved these changes Apr 18, 2023
View reviewed changes
Copy link
Owner

@JLLeitschuh JLLeitschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this!

@JLLeitschuh JLLeitschuh merged commit f27c1dd into main Apr 18, 2023
15 checks passed
@wakingrufus wakingrufus deleted the fix-isRootEditorConfig branch June 21, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLLeitschuh JLLeitschuh JLLeitschuh approved these changes

@Tapchicoma Tapchicoma Awaiting requested review from Tapchicoma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

isRootEditorConfig() method doesn't ever return true
2 participants
@wakingrufus @JLLeitschuh