fix: Use explicit getters and setters for common properties #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures values are correctly escaped. When setting properties using SetDescription, it is escaped. This ensures a well-formed iCal file. Using GetDescription returns the unescaped string, resulting in a well-rendered frontend.
JM-Lemmi
approved these changes
Feb 15, 2024
|
Fixing files that were ruined by this bug: find the number of files that contain three or more backslashes: replace three backslashes by two backslashes: replace any leftover lines that only contain two backslashes: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures values are correctly escaped.
When setting properties using SetDescription, it is escaped. This ensures a well-formed iCal file. Using GetDescription returns the unescaped string, resulting in a well-rendered frontend.
This is blocked by JM-Lemmi/golang-ical#7. Merging before that PR is merged, and then incorporated back into this repository via the submodule, will break things.