This repository has been archived by the owner on Jul 19, 2022. It is now read-only.
Overrides for 5.24.6 #152
Merged
Overrides for 5.24.6 #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Edzelopez should this be merged now? |
|
Yes, I believe so. However, we should really look to removing some of the overrides using the hook introduced in 5.24. |
|
Edsel, could you work on removing these overrides this week and pass to @seamuslee001 for QA? |
Hmm. So this should not be committed to master but to a client branch, or perhaps even into a theming file in a custom ext for that client. Can you take that out from here. Separately, can you review with Monish and Seamus what the best practice is for avoiding copy and paste in this context? |
… it contains grant fields and also replace a deprecated function with non deprecated function
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.