Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type declaration for play operation #120

Merged
merged 1 commit into from
Dec 19, 2018

Conversation

pduchesne
Copy link
Contributor

fixes #119

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.396% when pulling 9e3a7cf on pduchesne:fix_play_request_type into cf44467 on JMPerez:master.

@JMPerez JMPerez merged commit 932e72d into JMPerez:master Dec 19, 2018
@JMPerez
Copy link
Owner

JMPerez commented Dec 19, 2018

Thanks @pduchesne!

@samofwise
Copy link

@JMPerez @pduchesne Could you release this change to npm? I am currently trying to use the uri functionality of the play method in typescript.
You guys are amazing :D

@JMPerez
Copy link
Owner

JMPerez commented Feb 2, 2019

@samofwise Done! Released version 1.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Typescript] type definition for 'play' parameters is incomplete
4 participants