Add function overloading for typings in getUserPlaylists - Fixes #135 #156
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getUserPlaylists
function checks if the first parameter is a string, in which case it uses it as the userId, otherwise it assumes the request is for the current user and considers the input parameters asoptions
andcallback
.Passing undefined as userId assumes that the first parameter is options, but the code removes the first parameter.
Typescript supports the definition for function overloading, which is what's needed here https://www.typescriptlang.org/docs/handbook/functions.html#overloads