remove system.out references

java/src/jmri/jmrit/Sound.java

@@ -19,8 +19,6 @@
 import javax.sound.sampled.SourceDataLine;
 import javax.sound.sampled.UnsupportedAudioFileException;
 import jmri.util.FileUtil;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 /**
  * Provide simple way to load and play sounds in JMRI.
@@ -45,7 +43,6 @@ public class Sound {
     private boolean streamingStop = false;
     private AtomicReference<Clip> clipRef = new AtomicReference<>();
     private boolean autoClose = true;
-    private final static Logger log = LoggerFactory.getLogger(Sound.class);
 
     /**
      * Create a Sound object using the media file at path
@@ -308,7 +305,7 @@ public WavBuffer(byte[] content) {
                             + buffer[index + 5] * 256
                             + buffer[index + 6] * 256 * 256
                             + buffer[index + 7] * 256 * 256 * 256;
-                    System.out.println("index now " + index);
+                    log.debug("index now {}", index);
                 }
             }
             log.error("Didn't find fmt chunk");
@@ -383,7 +380,7 @@ public void run() {
                                     format.getFrameRate(), true);  // big endian
                     // update stream and format details
                     stream = AudioSystem.getAudioInputStream(newFormat, stream);
-                    System.out.println("Converted Audio format: " + newFormat);
+                    log.info("Converted Audio format: {}", newFormat);
                     format = newFormat;
                     log.debug("new converted Audio format: " + format);
                 }
@@ -460,4 +457,6 @@ private void setSensor(int mode) {
         }
 
     }
+
+    private final static org.slf4j.Logger log = org.slf4j.LoggerFactory.getLogger(Sound.class);
 }

java/src/jmri/jmrit/decoderdefn/DecoderIndexBuilder.java

@@ -1,7 +1,10 @@
 package jmri.jmrit.decoderdefn;
 
 /**
- * Update the decoder index and store as a command-line action
+ * Update the decoder index and store as a command-line action.
+ * <P>
+ * Not intended to be referenced from within JMRI itself, as this
+ * reconfigures logging for standalone operation.
  *
  * @author Bob Jacobsen Copyright (C) 2001, 2011, 2014
  * @author Randall Wood Copyright (C) 2013
@@ -11,6 +14,8 @@ public class DecoderIndexBuilder {
 
     // main entry point to run standalone
     static public void main(String[] args) {
+
+        // logging needed for code invoked from here
         String logFile = "default.lcf";
         try {
             if (new java.io.File(logFile).canRead()) {
@@ -22,7 +27,7 @@ static public void main(String[] args) {
             System.out.println("Exception starting logging: " + e);
         }
 
-        // print the location where the result is stored
+        // log the location where the result is stored
         System.out.println(jmri.util.FileUtil.getUserFilesPath() + "decoderIndex.xml"); // command line
 
         // recreate the index

java/src/jmri/jmrit/dispatcher/AutoActiveTrain.java

@@ -1419,8 +1419,7 @@ private synchronized void setTargetSpeedByProfile(float speedState) {
                     _autoEngineer.setHalt(true);
                 }
             } catch (Exception ex) {
-                log.error("setTargetSpeedByProfile crashed - Emergency Stop: " );
-                ex.printStackTrace();
+                log.error("setTargetSpeedByProfile crashed - Emergency Stop: ", ex );
                 _autoEngineer.slowToStop(false);
                 _targetSpeed = -1.0f;
                 _autoEngineer.setHalt(true);

java/src/jmri/jmrit/logix/Warrant.java

@@ -15,8 +15,6 @@
 import jmri.ThrottleListener;
 import jmri.implementation.SignalSpeedMap;
 import jmri.util.ThreadingUtil;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 /**
  * An Warrant contains the operating permissions and directives needed for a
@@ -1643,7 +1641,7 @@ public void run() {
                         javax.swing.SwingUtilities.invokeAndWait(allocateBlocks);
                     }
                     catch (Exception e) {
-                        e.printStackTrace();
+                        log.error("Exception in allocateBlocks", e);
                     }
                 }
             };
@@ -2819,5 +2817,5 @@ public int hashCode() {
         return (getSystemName().concat(_speedUtil.getDccAddress().toString())).hashCode();
     }
 
-    private final static Logger log = LoggerFactory.getLogger(Warrant.class);
+    private final static org.slf4j.Logger log = org.slf4j.LoggerFactory.getLogger(Warrant.class);
 }

java/src/jmri/jmrit/ussctc/TrafficRelay.java

@@ -35,7 +35,6 @@ public TrafficRelay(SignalHeadSection signal, CodeGroupThreeBits direction, Bean
         this.farSignal = signal;
         this.direction = direction;
         this.beans = beans;
-        System.out.println("bean count "+beans.length);
     }
 
     SignalHeadSection farSignal;

java/src/jmri/jmrix/can/cbus/swing/nodeconfig/NodeConfigToolPane.java

@@ -690,8 +690,7 @@ public boolean importData(JComponent c, Transferable t) {
                 try {
                     eventInJmriFormat = (String) t.getTransferData(DataFlavor.stringFlavor);
                 } catch (Exception e) {
-                    log.error("unable to get dragged address");
-                    e.printStackTrace();
+                    log.error("unable to get dragged address", e);
                     return false;
                 }
 

java/src/jmri/jmrix/openlcb/swing/downloader/LoaderPane.java

@@ -195,7 +195,7 @@ public void readFile(String filename) {
         File file = new File(filename);
         try (FileInputStream fis = new FileInputStream(file)) {
 
-            System.out.println("Total file size to read (in bytes) : "
+            log.info("Total file size to read (in bytes) : "
                     + fis.available());
             fdata = new byte[fis.available()];
             int i = 0;