Skip to content

Commit

Permalink
move to BoxLayout; common size definition
Browse files Browse the repository at this point in the history
  • Loading branch information
@bobjacobsen
bobjacobsen committed Oct 4, 2018
1 parent 68042a6 commit aa9bd61
Showing 1 changed file with 19 additions and 12 deletions.
31 changes: 19 additions & 12 deletions java/src/jmri/jmrit/signalling/SignallingPanel.java
View file
Expand Up @@ -2,6 +2,7 @@

import java.awt.BorderLayout;
import java.awt.Component;
import java.awt.Dimension;
import java.awt.FlowLayout;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
Expand Down Expand Up @@ -85,7 +86,10 @@ public class SignallingPanel extends jmri.util.swing.JmriPanel {
jmri.NamedBeanHandleManager nbhm = jmri.InstanceManager.getDefault(jmri.NamedBeanHandleManager.class);

JFrame jFrame;


// Siae of the individual bean tables inside the shared pane
static final Dimension TABLESIZEPREFERRED = new Dimension(720, 200);

/**
* Create an empty JPanel to configure a new Signal Mast Logic.
*
Expand Down Expand Up @@ -146,19 +150,21 @@ public SignallingPanel(SignalMast source, SignalMast dest, JFrame frame) {
destMastBox = new JmriBeanComboBox(smm, destMast, JmriBeanComboBox.DisplayOptions.DISPLAYNAME);

JPanel containerPanel = new JPanel();
containerPanel.setLayout(new BorderLayout());
containerPanel.setLayout(new BoxLayout(containerPanel, BoxLayout.Y_AXIS));

JPanel header = new JPanel();
header.setLayout(new BoxLayout(header, BoxLayout.Y_AXIS));

JPanel sourcePanel = new JPanel();
sourcePanel.setLayout(new BoxLayout(sourcePanel, BoxLayout.X_AXIS));
sourcePanel.add(sourceMastLabel);
sourcePanel.add(sourceMastBox);
sourcePanel.add(fixedSourceMastLabel);

header.add(sourcePanel);

JPanel destPanel = new JPanel();
destPanel.setLayout(new BoxLayout(destPanel, BoxLayout.X_AXIS));
destPanel.add(destMastLabel);
destPanel.add(destMastBox);
destPanel.add(fixedDestMastLabel);
Expand Down Expand Up @@ -274,15 +280,16 @@ public void actionPerformed(ActionEvent e) {
py.add(new JLabel(" " + Bundle.getMessage("Elements"))); // NOI18N
header.add(py);

containerPanel.add(header, BorderLayout.NORTH);
containerPanel.add(header);

JTabbedPane detailsTab = new JTabbedPane();
detailsTab.setLayout(new BoxLayout(detailsTab, BoxLayout.Y_AXIS));
detailsTab.add(Bundle.getMessage("Blocks"), buildBlocksPanel()); // NOI18N
detailsTab.add(Bundle.getMessage("Turnouts"), buildTurnoutPanel()); // NOI18N
detailsTab.add(Bundle.getMessage("Sensors"), buildSensorPanel()); // NOI18N
detailsTab.add(Bundle.getMessage("SignalMasts"), buildSignalMastPanel()); // NOI18N

containerPanel.add(detailsTab, BorderLayout.CENTER);
containerPanel.add(detailsTab);

JPanel footer = new JPanel();
footer.setLayout(new FlowLayout(FlowLayout.TRAILING));
Expand Down Expand Up @@ -318,7 +325,7 @@ public void actionPerformed(ActionEvent e) {
applyButton.setToolTipText(Bundle.getMessage("ApplyButtonToolTip")); // NOI18N
applyButton.setVisible(true);

containerPanel.add(footer, BorderLayout.SOUTH);
containerPanel.add(footer);

add(containerPanel);
if (sourceMast != null) { // edit an existing SML, fix source mast
Expand Down Expand Up @@ -429,7 +436,7 @@ JPanel buildBlocksPanel() {
_blockModel.configStateColumn(manualBlockTable); // create static comboBox in State column
manualBlockTable.setRowSorter(manualBlockSorter);
manualBlockTable.setRowSelectionAllowed(false);
manualBlockTable.setPreferredScrollableViewportSize(new java.awt.Dimension(480, 100));
manualBlockTable.setPreferredScrollableViewportSize(TABLESIZEPREFERRED);
// JComboBox<String> stateCCombo = new JComboBox<>(); // moved to ManualBlockTable class

TableColumnModel _manualBlockColumnModel = manualBlockTable.getColumnModel();
Expand Down Expand Up @@ -476,7 +483,7 @@ JPanel buildBlocksPanel() {
RowSorterUtil.setSortOrder(autoBlockSorter, AutoBlockModel.SNAME_COLUMN, SortOrder.ASCENDING);
autoBlockTable.setRowSorter(autoBlockSorter);
autoBlockTable.setRowSelectionAllowed(false);
autoBlockTable.setPreferredScrollableViewportSize(new java.awt.Dimension(480, 100));
autoBlockTable.setPreferredScrollableViewportSize(TABLESIZEPREFERRED);

TableColumnModel _autoBlockColumnModel = autoBlockTable.getColumnModel();
TableColumn sNameColumnA = _autoBlockColumnModel.
Expand Down Expand Up @@ -559,7 +566,7 @@ JPanel buildTurnoutPanel() {
_turnoutModel.configStateColumn(manualTurnoutTable); // create static comboBox in State column
manualTurnoutTable.setRowSorter(manualTurnoutSorter);
manualTurnoutTable.setRowSelectionAllowed(false);
manualTurnoutTable.setPreferredScrollableViewportSize(new java.awt.Dimension(480, 100));
manualTurnoutTable.setPreferredScrollableViewportSize(TABLESIZEPREFERRED);
// JComboBox<String> stateCCombo = new JComboBox<>(); // moved to ManualTurnoutTable class

TableColumnModel _manualTurnoutColumnModel = manualTurnoutTable.getColumnModel();
Expand Down Expand Up @@ -607,7 +614,7 @@ JPanel buildTurnoutPanel() {
RowSorterUtil.setSortOrder(autoTurnoutSorter, AutoTurnoutModel.SNAME_COLUMN, SortOrder.ASCENDING);
autoTurnoutTable.setRowSorter(autoTurnoutSorter);
autoTurnoutTable.setRowSelectionAllowed(false);
autoTurnoutTable.setPreferredScrollableViewportSize(new java.awt.Dimension(480, 100));
autoTurnoutTable.setPreferredScrollableViewportSize(TABLESIZEPREFERRED);

TableColumnModel _autoTurnoutColumnModel = autoTurnoutTable.getColumnModel();
TableColumn sNameColumnA = _autoTurnoutColumnModel.
Expand Down Expand Up @@ -678,7 +685,7 @@ JPanel buildSensorPanel() {
_sensorModel.configStateColumn(manualSensorTable); // create static comboBox in State column
manualSensorTable.setRowSorter(manualSensorSorter);
manualSensorTable.setRowSelectionAllowed(false);
manualSensorTable.setPreferredScrollableViewportSize(new java.awt.Dimension(480, 100));
manualSensorTable.setPreferredScrollableViewportSize(TABLESIZEPREFERRED);
//stateCCombo = new JComboBox<>(); // moved to ManualSensorTable class

TableColumnModel _manualSensorColumnModel = manualSensorTable.getColumnModel();
Expand Down Expand Up @@ -753,7 +760,7 @@ JPanel buildSignalMastPanel() {
_signalMastModel.configStateColumn(manualSignalMastTable); // create mast (row) specific comboBox in Aspect column
manualSignalMastTable.setRowSorter(sorter);
manualSignalMastTable.setRowSelectionAllowed(false);
manualSignalMastTable.setPreferredScrollableViewportSize(new java.awt.Dimension(480, 100));
manualSignalMastTable.setPreferredScrollableViewportSize(TABLESIZEPREFERRED);

TableColumnModel _manualSignalMastColumnModel = manualSignalMastTable.getColumnModel();
TableColumn includeColumnC = _manualSignalMastColumnModel.
Expand Down Expand Up @@ -797,7 +804,7 @@ JPanel buildSignalMastPanel() {
RowSorterUtil.setSortOrder(autoMastSorter, AutoMastModel.SNAME_COLUMN, SortOrder.ASCENDING);
autoMastTable.setRowSorter(autoMastSorter);
autoMastTable.setRowSelectionAllowed(false);
autoMastTable.setPreferredScrollableViewportSize(new java.awt.Dimension(480, 100));
autoMastTable.setPreferredScrollableViewportSize(TABLESIZEPREFERRED);

TableColumnModel _autoMastColumnModel = autoMastTable.getColumnModel();
TableColumn sNameColumnA = _autoMastColumnModel.
Expand Down

0 comments on commit aa9bd61

Please sign in to comment.