Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modbus - removed from the Systems Manufacturing List #12991

Open
truittm opened this issue Mar 30, 2024 · 8 comments
Open

Modbus - removed from the Systems Manufacturing List #12991

truittm opened this issue Mar 30, 2024 · 8 comments
Labels
Pending closure This issue or PR has not been updated for a while

Comments

@truittm
Copy link

truittm commented Mar 30, 2024

Release 5.6 does not have a listing for the Modbus protocol. I don't know when this removed or why, but I was hoping that this protocol would be progressed, especially the Master mode, which would allow easier use of easily developed low cost slave devices that can be multidropped (up to 35 devices) on a single RS 485 half duplex. At the moment I hoped that I could build a "network master" that uses two Master communicators to poll the JMRI Modbus slave system and then retransmit that send commands to a series of multidropped slaves.

This of course is based on the ability of Modbus communication via JMRI and the reinsertion of that capability into the releases and possibly that addition of a Master mode.

@bobjacobsen
Copy link
Member

As near as I can tell from reading the code, the Modbus implementation was never completed. There was some work in 2014/2105 but it only got as far as documentation. There doesn't seem to have ever been working code there.

But I may have gotten this wrong. Did you have it working at some point?

@bobjacobsen
Copy link
Member

bobjacobsen commented Mar 30, 2024

In case anybody looks into this again, the commit that removed the documentation-only packages was:

commit d829a04451a0db96f4d5dab13df3fff0cf3239aa
Author: Randall Wood <randall.h.wood@alexandriasoftware.com>
Date:   Sun Dec 31 08:48:39 2017 -0500

    Remove empty packages
    
    Remove packages which only contain a package.html and COPYING file.

 java/src/apps/wizard/COPYING                       | 372 ---------------------
 java/src/apps/wizard/package.html                  |  65 ----
 .../src/jmri/jmrix/modbus/common/package-info.java |  13 -
 .../src/jmri/jmrix/modbus/master/package-info.java |  12 -
 java/src/jmri/jmrix/modbus/package-info.java       |  12 -
 java/src/jmri/jmrix/modbus/slave/package-info.java |  11 -
 java/src/jmri/jmrix/rps/csvinput/COPYING           | 372 ---------------------
 java/src/jmri/jmrix/rps/csvinput/package.html      |  27 --
 java/src/jmri/jmrix/rps/display/COPYING            | 372 ---------------------
 java/src/jmri/jmrix/rps/display/package.html       |  30 --
 10 files changed, 1286 deletions(-)
 delete mode 100644 java/src/apps/wizard/COPYING
 delete mode 100644 java/src/apps/wizard/package.html
 delete mode 100644 java/src/jmri/jmrix/modbus/common/package-info.java
 delete mode 100644 java/src/jmri/jmrix/modbus/master/package-info.java
 delete mode 100644 java/src/jmri/jmrix/modbus/package-info.java
 delete mode 100644 java/src/jmri/jmrix/modbus/slave/package-info.java
 delete mode 100644 java/src/jmri/jmrix/rps/csvinput/COPYING
 delete mode 100644 java/src/jmri/jmrix/rps/csvinput/package.html
 delete mode 100644 java/src/jmri/jmrix/rps/display/COPYING
 delete mode 100644 java/src/jmri/jmrix/rps/display/package.html

This is credited to #4665

@truittm
Copy link
Author

truittm commented Mar 30, 2024 via email

@bobjacobsen
Copy link
Member

C/MRI is very similar, though much simpler, than ModBus. JMRI acts as a master, polling each node in turn over an RS485 bus. (I think the hardware for the connection is essentially identical). You can read and write individual bits, which in turn are connected to sensors and turnouts, etc. There are Arduino libraries that implement it, if that's helpful.

For more information on the protocol:
https://www.nmra.org/sites/default/files/standards/sandrp/Other_Specifications/lcs-9.10.1_cmrinet_v1.1.pdf

It might be possible to add ModBus to JMRI, I think. But the person who started on it is no longer with us, and I'm not sure who might be motivated to do it. I'll ask around.

@KenC57
Copy link
Contributor

KenC57 commented Mar 31, 2024 via email

@bobjacobsen
Copy link
Member

OK. Happy to help with what I can, but I don't have much ModBus knowledge nor anything to test against.

@truittm
Copy link
Author

truittm commented Apr 1, 2024 via email

Copy link

This issue is stale because it has been open for 45 days with no activity.

@github-actions github-actions bot added the Pending closure This issue or PR has not been updated for a while label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pending closure This issue or PR has not been updated for a while
Projects
None yet
Development

No branches or pull requests

3 participants