Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop release-4.2 #316

Closed
mattharris opened this issue Dec 5, 2015 · 9 comments
Closed

Develop release-4.2 #316

mattharris opened this issue Dec 5, 2015 · 9 comments
Milestone

Comments

@mattharris
Copy link
Member

First pass at release note for 4.2 has been submitted.

Please review this (it's just a concatenation of pretty much everything from the 4.1.x series).

Thanks.

@mattharris mattharris added this to the 4.2 milestone Dec 5, 2015
@mattharris
Copy link
Member Author

Production Release 4.2 will be built based upon 4.1.6.

@mattharris
Copy link
Member Author

The release-4.2 branch now exists.

@mattharris
Copy link
Member Author

First candidate files for JMRI 4.2 are available in the usual place:

http://builds.jmri.org/jenkins/job/Test%20Releases/job/4.2/

@mattharris
Copy link
Member Author

Pausing release at the moment due to issue noticed by Dan (copied from developers list):

Using Panel Editor, I found that if I select a blinking icon for a sensor icon, that it doesn't blink. I checked the other test versions 4.1.1 through 4.1.6 and they all have the same problem. Version 4.0.1 works correctly. If I just add a blinking icon to the panel, it does blink, and it seems to work ok if I assign blinking icons to turnouts, so the problem seems to be with sensors.
Testing using NCE simulator.

Here's an example of one of the icons that I'm having problems with:

program:resources/icons/USS/sensor/blink/red-b.gif

Dan

@mattharris
Copy link
Member Author

Do we feel that this is serious enough to stop the release?

Only, we really should try and avoid pushing out a 4.2.1. Yes, we have
done this in the past, but it can get a bit messy.

Thoughts?

(sent also to jmri-developers)

@KenC57
Copy link
Contributor

KenC57 commented Dec 21, 2015

I know we will hear of this from the users. A number of them (ok at least 5
or 10) use blinking icons for either signals or control panels and expect
them to flash. Non-flashing means something else. I recall helping (at
least) twice on how to substitute the icons to make that happen.

-Ken Cameron, Member JMRI Dev Team

www.jmri.org

www.fingerlakeslivesteamers.org

www.cnymod.com

www.syracusemodelrr.org

@DanielBoudreau
Copy link
Contributor

I went back and retested, and I was wrong to report that versions 4.1.1 through 4.1.4 had the blinking sensor icon problem. The first release that shows the problem is version 4.1.5. So I think this problem was introduced in the last 4 weeks. History shows that Pete C. was making changes to the sensor code to fix an issue reported by Walt.

Dan

@mattharris
Copy link
Member Author

Pete's updates have been brought in via #401 for the release-4.2 branch

@mattharris
Copy link
Member Author

Closing as part of release process

bobjacobsen pushed a commit to bobjacobsen/JMRI that referenced this issue Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants